Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promotions schema for cart #6772

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

vanpho93
Copy link
Member

@vanpho93 vanpho93 commented Feb 2, 2023

Resolves #issueNumber
Impact: major
Type: feature

Issue

  • Unable to get applied promotions for cart
  • Save too much promotion data into cart

Solution

  • Add promotion / discount fields into cart schema
  • Clean up promotions before saving

Signed-off-by: vanpho93 <vanpho02@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

⚠️ No Changeset found

Latest commit: d288e4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zenweasel zenweasel merged commit f56ba81 into feat/promotions Feb 6, 2023
@zenweasel zenweasel deleted the feat/promotions-schema-for-cart branch February 6, 2023 08:18
vanpho93 pushed a commit that referenced this pull request Apr 24, 2023
…-for-cart

feat: promotions schema for cart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants