Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archive coupon mutation #6782

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

vanpho93
Copy link
Member

@vanpho93 vanpho93 commented Feb 7, 2023

Resolves #issueNumber
Impact: major
Type: feature

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023

⚠️ No Changeset found

Latest commit: ce0d117

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@sujithvn sujithvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Noticed that the input CreateStandardCouponInput seems to be defined twice in schema.graphql

Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93
Copy link
Member Author

Noticed that the input CreateStandardCouponInput seems to be defined twice in schema.graphql

Thanks @sujithvn, I updated that.

@vanpho93 vanpho93 merged commit 9db5e13 into feat/coupons Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants