Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional fields to promotions #6788

Merged
merged 3 commits into from
Feb 9, 2023
Merged

feat: add additional fields to promotions #6788

merged 3 commits into from
Feb 9, 2023

Conversation

vannguyenn
Copy link
Contributor

@vannguyenn
feat: add additional fields to promotions
b637a08 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@vannguyenn
fix: lock file
3b431a5 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023 •
edited

⚠️ No Changeset found

Latest commit: 9649323

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vannguyenn vannguyenn mentioned this pull request Feb 9, 2023
Merged
vanpho93
vanpho93 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@vanpho93 vanpho93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert snyk changes in pnpm-lock.yaml.

zenweasel
zenweasel approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as Brian. Otherwise looks good

@vannguyenn
fix: revert snyk changes
9649323 
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@vannguyenn vannguyenn merged commit 4e2b811 into feat/promotions Feb 9, 2023
@vannguyenn vannguyenn deleted the feat/addtional-fields branch February 9, 2023 08:46
vanpho93 pushed a commit that referenced this pull request Apr 24, 2023
@vannguyenn @vanpho93
Merge pull request #6788 from reactioncommerce/feat/addtional-fields
31d9f77 
feat: add additional fields to promotions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenweasel zenweasel zenweasel approved these changes

@vanpho93 vanpho93 vanpho93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vannguyenn @zenweasel @vanpho93