Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert accidental changes #6789

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: revert accidental changes #6789

merged 1 commit into from
Feb 13, 2023

Conversation

vannguyenn
Copy link
Contributor

Signed-off-by: Chloe pinkcloudvnn@gmail.com

Resolves #issueNumber
Impact: breaking|critical|major|minor
Type: feature|bugfix|performance|test|style|refactor|docs|chore

Issue

Description of the issue this PR is solving, why it's happening, and how to reproduce it. This may differ from the original ticket as you now have more information at your disposal.

Solution

Summarize your solution to the problem. Please include short descriptions of any solutions you tested before arriving at your final solution. This will help reviewers know why you decided to solve this problem in this particular way and will speed up the review process.

If you're solving a UIX related issue, please attach screen-caps or gifs showing how your solution differs from the issue.

Breaking changes

If you have a breaking changes, list them here, otherwise list none.

Examples of breaking changes include changing file names, moving files, deleting files, renaming functions or exports, or changes to code which might cause previous versions of Reaction or third-party code not to work as expected.

Note any work that you did to mitigate the effect of any breaking changes such as creating migrations, deprecation warnings, etc.

Testing

  1. List the steps needed for testing your change in this section.
  2. Assume that testers already know how to start the app, and do the basic setup tasks.
  3. Be detailed enough that someone can work through it without being too granular

More detail for what each of these sections should include are available in our Contributing Docs.

Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023

⚠️ No Changeset found

Latest commit: 562f8dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brent-hoover brent-hoover merged commit e6ab079 into feat/promotions Feb 13, 2023
vanpho93 pushed a commit that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants