Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should query un-archived coupon in promotion #6801

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

vannguyenn
Copy link
Contributor

When retrieving the coupon for a promotion, we should filter out the archived coupon.

Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2023

⚠️ No Changeset found

Latest commit: 4a614a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zenweasel zenweasel merged commit 7d6032c into feat/coupons Feb 16, 2023
@zenweasel zenweasel deleted the fix/archived-coupon-promotion branch February 16, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants