This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
I don't really know how this started, but this line was causing
analytics
to always be undefined in that router context below it, so theonUpdate
hook was never able to call it. Hopping into the browser console and runninganalytics.page()
worked every time, but the router never called it. I removed that one line and now it works every time. Old unmaintained Meteor packages FTW!The CI change here is just pinning the older Node version because this project uses Meteor 1.5.
Build was successful and container tests passed.
https://circleci.com/gh/reactioncommerce/redoc/199
Once this is merged to master, it should get automatically deployed by Docker Cloud and our analytics should start working again. Note that there is now a new site set up for
docs.reactioncommerce.com
in both Segment and GA.