Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Fix Segment analytics #91

Merged
merged 4 commits into from
Feb 5, 2018
Merged

Fix Segment analytics #91

merged 4 commits into from
Feb 5, 2018

Conversation

jshimko
Copy link
Contributor

@jshimko jshimko commented Feb 5, 2018

Fixes #90

I don't really know how this started, but this line was causing analytics to always be undefined in that router context below it, so the onUpdate hook was never able to call it. Hopping into the browser console and running analytics.page() worked every time, but the router never called it. I removed that one line and now it works every time. Old unmaintained Meteor packages FTW!

The CI change here is just pinning the older Node version because this project uses Meteor 1.5.

Build was successful and container tests passed.

https://circleci.com/gh/reactioncommerce/redoc/199

Once this is merged to master, it should get automatically deployed by Docker Cloud and our analytics should start working again. Note that there is now a new site set up for docs.reactioncommerce.com in both Segment and GA.

Copy link

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 -- I will check Google Analytics and Segment after this is merged to check if all's good.

@jshimko
Copy link
Contributor Author

jshimko commented Feb 5, 2018

FWIW, you should already see some data in both Segment and GA from my local tests.

@jshimko jshimko merged commit 72ae336 into master Feb 5, 2018
@jshimko jshimko deleted the fix-segment-analytics branch February 5, 2018 20:13
@machikoyasuda
Copy link

@machikoyasuda
Copy link

Segment is tracking data ✔️

screen shot 2018-02-05 at 12 14 35 pm
screen shot 2018-02-05 at 12 14 41 pm

Example:

  path: '/reaction-docs/master/installation-windows',
  referrer: 'http://localhost:3000/reaction-docs/master/plugin-schemas-8',
  search: '',
  title: 'Reaction Docs',
  url: 'http://localhost:3000/reaction-docs/master/installation-windows'
});```

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants