Removes a partial sentence in the javadoc #370
Conversation
| @@ -128,7 +128,6 @@ public long maxElementsFromPublisher() { | |||
|
|
|||
| /** | |||
| * Override and return {@code true} in order to skip executing tests marked as {@code Stochastic}. | |||
| * Such tests MAY sometimes fail even though the impl | |||
There was a problem hiding this comment.
Or simply paraphrase the docs from tck/README:
Stochastic tests can yield false positives ("be green") even if for some case, the given implementation may violate the tested behaviour. If for some reason, a stochastic test fails for your implementation, yet you are confident the implementation is correct you can disable them using this flag. Please contact the working group on https://github.com/reactive-streams/reactive-streams-jvm in case you encounter such issue with the tests.
There was a problem hiding this comment.
There was a problem hiding this comment.
Good point. I'll add:
"Stochastic in this case means that the Rule is impossible or infeasible to deterministically verify— usually this means that this test case can yield false positives ("be green") even if for some case, the given implementation may violate the tested behaviour."
viktorklang
force-pushed
the
wip-278-remove-partial-doc-√
branch
from
535f59a
to
b1e5b1d
Compare
The original issue #278 has been open for almost 2 years with no one else commenting.
Improving the status quo by removing the partial sentence for now.