Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: Improve stream manager against disconnects #3041

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Apr 30, 2024

Disconnects can happen when device is forced offline, or sometimes even when app is in background for a long time.

Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: d51851a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (f6524a3) to head (d51851a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3041   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         123      123           
  Lines        2204     2204           
  Branches      452      452           
=======================================
  Hits         2176     2176           
  Misses         17       17           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker marked this pull request as ready for review June 15, 2024 08:53
@ntucker ntucker changed the title enhance: Improve stream manager against disconnects demo: Improve stream manager against disconnects Jun 15, 2024
@ntucker ntucker merged commit 39d890e into master Jun 15, 2024
21 checks passed
@ntucker ntucker deleted the stream-manager branch June 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant