Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo: Improve stream manager against disconnects #3041

Merged
merged 1 commit into from
Jun 15, 2024
Merged

demo: Improve stream manager against disconnects #3041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/coin-app/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const spouts = JSONSpout()(
getManagers: () => {
return [
new StreamManager(
new WebSocket('wss://ws-feed.exchange.coinbase.com'),
() => new WebSocket('wss://ws-feed.exchange.coinbase.com'),
{ ticker: getTicker },
),
...getManagers(),
Expand Down
55 changes: 45 additions & 10 deletions examples/coin-app/src/resources/StreamManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,41 @@ export default class StreamManager implements Manager {
[];

protected product_ids: string[] = [];
private attempts = 0;
protected declare connect: () => void;

constructor(
evtSource: WebSocket, // | EventSource,
evtSource: () => WebSocket, // | EventSource,
endpoints: Record<string, EndpointInterface>,
) {
this.evtSource = evtSource;
this.endpoints = endpoints;

this.middleware = controller => {
this.evtSource.onmessage = event => {
try {
const msg = JSON.parse(event.data);
this.handleMessage(controller, msg);
} catch (e) {
console.error('Failed to handle message');
console.error(e);
}
this.connect = () => {
this.evtSource = evtSource();
this.evtSource.onmessage = event => {
try {
const msg = JSON.parse(event.data);
this.handleMessage(controller, msg);
} catch (e) {
console.error('Failed to handle message');
console.error(e);
}
};
this.evtSource.onopen = () => {
console.info('WebSocket connected');
// Reset reconnection attempts after a successful connection
this.attempts = 0;
};
this.evtSource.onclose = () => {
console.info('WebSocket disconnected');
this.reconnect();
};
this.evtSource.onerror = error => {
console.error('WebSocket error:', error);
// Ensures that the onclose handler gets triggered for reconnection
this.evtSource.close();
};
};
return next => async action => {
switch (action.type) {
Expand Down Expand Up @@ -110,13 +128,30 @@ export default class StreamManager implements Manager {
}

init() {
this.connect();
this.evtSource.addEventListener('open', event => {
//this.msgQueue.forEach((msg) => this.evtSource.send(msg));
this.flushSubscribe();
});
}

reconnect() {
// Exponential backoff formula to gradually increase the reconnection time
setTimeout(
() => {
console.info(
`Attempting to reconnect... (Attempt: ${this.attempts + 1})`,
);
this.attempts++;
this.connect();
},
Math.min(10000, (Math.pow(2, this.attempts) - 1) * 1000),
);
}

cleanup() {
// remove our event handler that attempts reconnection
this.evtSource.onclose = null;
this.evtSource.close();
}

Expand Down
2 changes: 1 addition & 1 deletion examples/nextjs/app/Provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { getTicker } from 'resources/Ticker';
const managers =
typeof window === 'undefined' ? getDefaultManagers() : (
[
new StreamManager(new WebSocket('wss://ws-feed.exchange.coinbase.com'), {
new StreamManager(() => new WebSocket('wss://ws-feed.exchange.coinbase.com'), {
ticker: getTicker,
}),
...getDefaultManagers(),
Expand Down
63 changes: 49 additions & 14 deletions examples/nextjs/resources/StreamManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,30 +7,48 @@ import { ActionTypes, Controller, actionTypes } from '@data-client/react';
* https://docs.cloud.coinbase.com/advanced-trade-api/docs/ws-overview
*/
export default class StreamManager implements Manager {
protected middleware: Middleware<ActionTypes>;
protected evtSource: WebSocket; // | EventSource;
protected endpoints: Record<string, EndpointInterface>;
protected declare middleware: Middleware<ActionTypes>;
protected declare evtSource: WebSocket; // | EventSource;
protected declare endpoints: Record<string, EndpointInterface>;
protected msgQueue: (string | ArrayBufferLike | Blob | ArrayBufferView)[] =
[];

protected product_ids: string[] = [];
private attempts = 0;
protected declare connect: () => void;

constructor(
evtSource: WebSocket, // | EventSource,
evtSource: () => WebSocket, // | EventSource,
endpoints: Record<string, EndpointInterface>,
) {
this.evtSource = evtSource;
this.endpoints = endpoints;

this.middleware = controller => {
this.evtSource.onmessage = event => {
try {
const msg = JSON.parse(event.data);
this.handleMessage(controller, msg);
} catch (e) {
console.error('Failed to handle message');
console.error(e);
}
this.connect = () => {
this.evtSource = evtSource();
this.evtSource.onmessage = event => {
try {
const msg = JSON.parse(event.data);
this.handleMessage(controller, msg);
} catch (e) {
console.error('Failed to handle message');
console.error(e);
}
};
this.evtSource.onopen = () => {
console.info('WebSocket connected');
// Reset reconnection attempts after a successful connection
this.attempts = 0;
};
this.evtSource.onclose = () => {
console.info('WebSocket disconnected');
this.reconnect();
};
this.evtSource.onerror = error => {
console.error('WebSocket error:', error);
// Ensures that the onclose handler gets triggered for reconnection
this.evtSource.close();
};
};
return next => async action => {
switch (action.type) {
Expand Down Expand Up @@ -110,14 +128,31 @@ export default class StreamManager implements Manager {
}

init() {
this.connect();
this.evtSource.addEventListener('open', event => {
//this.msgQueue.forEach((msg) => this.evtSource.send(msg));
this.flushSubscribe();
});
}

reconnect() {
// Exponential backoff formula to gradually increase the reconnection time
setTimeout(
() => {
console.info(
`Attempting to reconnect... (Attempt: ${this.attempts + 1})`,
);
this.attempts++;
this.connect();
},
Math.min(10000, (Math.pow(2, this.attempts) - 1) * 1000),
);
}

cleanup() {
//this.evtSource.close();
// remove our event handler that attempts reconnection
this.evtSource.onclose = null;
this.evtSource.close();
}

getMiddleware() {
Expand Down