Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cleanup-gcloud script, updating helm-deploy to create namespace if it doesn't exist #158

Merged
merged 2 commits into from
May 22, 2018
Merged

Adding cleanup-gcloud script, updating helm-deploy to create namespace if it doesn't exist #158

merged 2 commits into from
May 22, 2018

Conversation

robscott
Copy link
Contributor

A couple small additions to help with common gcloud and helm tasks.

@robscott robscott force-pushed the rs/gcloud-and-helm-updates branch from b3b7220 to 2355abb Compare May 18, 2018 14:01
@sudermanjr
Copy link
Member

Doesn't a helm install create the namespace already if it doesn't exist?

@robscott
Copy link
Contributor Author

I think helm install does that, but there seems to be some inconsistency with the helm upgrade we're using: helm/helm#2013. Although there are other workarounds, this provides a fairly straightforward way to mitigate that potential issue.

@robscott robscott merged commit 9400924 into master May 22, 2018
@robscott robscott deleted the rs/gcloud-and-helm-updates branch August 10, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosullivan dosullivan dosullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robscott @sudermanjr @dosullivan