Allow referencing Akavache.Drawing from NetStandard project #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a netstandard library to continue working with IBitmaps in Akavache, provided the native host registers the IPlatformBitmapLoader.
|
|
|
This would likely bring back the Mac compile issues so bit hesitant to merge this one. |
glennawatson
approved these changes
Jan 29, 2020
|
Given its the drawing package not the main one should be fine to unblock blazor and wasm users. So I'll merge it in. Thanks for the pr |
|
Hi @john-manktelow this will be included in the release going out tonight for Akavache. Thanks for your help again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Includes Akavache.Drawing in the .sln file
Adds netstandard2.0 the target frameworks for Akavache.Drawing
What is the current behavior?
After the bitmap mixing were moved to Akavache.Drawing, they could no longer be used in a .NET Standard project.
For example, on macOS, the following warning would be raised:
What is the new behavior?
Akavache.Drawing's targets include netstandard2.0.
Registrationsis still included, but does not callRegisterPlatformBitmapLoaderwhen built for NetStandard.What might this PR break?
The test pass rate is unchanged and the change is only to the newly separate Drawing project.
Please check if the PR fulfills these requirements
Not sure how to unit test something like this.
Other information: