Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit: added files #1

Merged
merged 14 commits into from
Jun 16, 2019
Merged

Initial commit: added files #1

merged 14 commits into from
Jun 16, 2019

Conversation

weitzhandler
Copy link
Contributor

No description provided.

@jeromelaban
Copy link
Contributor

This change relies on the presence of the PlatformEnlightenmentProvider.Current API, which marked obsolete.

It should be noted to the maintainers of Rx that this API is important for extensibility, or that the content of this package should be merged with Rx (by testing for the threading APIs support, instead of relying on the platform name).

@todo
Copy link

todo bot commented Jun 13, 2019

Comment the next line if you want to checkin your web deploy settings

https://github.com/reactiveui/System.Reactive.Wasm/blob/888edf0ba6b467785d0a0dfe69197ff77a8c4dda/.gitignore#L147-L152


This comment was generated by todo based on a TODO comment in 888edf0 in #1. cc @weitzhandler.

@glennawatson
Copy link
Collaborator

Close/reopen to trigger CI, I hope :)

@glennawatson
Copy link
Collaborator

So we are going to require some tests for the CI to be happy and probably a good idea to get some anyway. Not sure the best way to approach these tests.

@glennawatson
Copy link
Collaborator

@jeromelaban Most of your comments became displaced due to moving around to match our coding standards. Any chance you can check again and see if that's what you meant?

@weitzhandler
Copy link
Contributor Author

@glennawatson
So we are going to require some tests for the CI to be happy and probably a good idea to get some anyway. Not sure the best way to approach these tests.

@jeromelaban
I have no clue how I'd implement those tests.
Any guidance on how to write some tests for wasm?

What I had in mind, was adding a reference to Uno.UI to the test project, and adapt some of the Rx tests to work against Uno UI instead, for instance, in the ControlSchedulerTest, instead of using the WinForms Label, use the Uno one, though I don't know if that makes sense, because it might work totally different in Wasm. Don't know how to mock a wasm env.

@glennawatson glennawatson merged commit 72771c3 into reactiveui:master Jun 16, 2019
@lock lock bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants