Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix validation context, unit tests, warnings #13

Merged
merged 4 commits into from Mar 20, 2019
Merged

fix: fix validation context, unit tests, warnings #13

merged 4 commits into from Mar 20, 2019

Conversation

glennawatson
Copy link
Collaborator

  • Added the API generator validations
  • Fixed the fact that validation context would not run all the way through, since Validations would be null when needed in the observables
  • Added the API validation to make sure that API changes are shown.

@glennawatson glennawatson requested a review from a team March 20, 2019 18:23
@glennawatson
Copy link
Collaborator Author

Most of the warning fixups were already done by @alexmartinezm

@glennawatson glennawatson mentioned this pull request Mar 20, 2019
Closed
RLittlesII
RLittlesII approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@RLittlesII RLittlesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RLittlesII RLittlesII merged commit ee8525d into master Mar 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-port-alex-changes branch March 20, 2019 19:13
@alexmartinezm alexmartinezm mentioned this pull request Mar 20, 2019
Closed
@lock
Copy link

lock bot commented Jun 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RLittlesII RLittlesII RLittlesII approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glennawatson @RLittlesII @alexmartinezm