Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Correct ValidationText Error Message #150

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

worldbeater
Copy link
Collaborator

@worldbeater worldbeater commented Oct 22, 2020

What kind of change does this PR introduce?

This PR corrects the ValidationText error message. Guessing the message was accidentally made as misleading. Also, in the scope of this PR, we are intending to use the opportunity to ship a new 1.8.x build to NuGet.

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #150 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   62.06%   62.06%           
=======================================
  Files          16       16           
  Lines         912      912           
=======================================
  Hits          566      566           
  Misses        346      346           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2548cc0...c1b5c9a. Read the comment docs.

@worldbeater worldbeater merged commit 145bb70 into main Oct 22, 2020
@worldbeater worldbeater deleted the correct-error-message branch October 22, 2020 10:11
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants