-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing ReactivePage, ReactiveUserControl and DependencyProperties cha…
…nge notification for WinUI 3 (#2902) * Added support for WinUI3 desktop * ReactivePage, ReactiveUserControl, DependencyProperties now work. Also, The ReactiveUI.WinUI is getting loaded instead of .net startandard dll. * Updated DispatcherQueueScheduler xml docs * Update .gitignore
- Loading branch information
1 parent
66a4d38
commit b647a43
Showing
11 changed files
with
210 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
161 changes: 161 additions & 0 deletions
161
src/ReactiveUI.WinUI/DependencyObjectObservableForProperty.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| // Copyright (c) 2021 .NET Foundation and Contributors. All rights reserved. | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for full license information. | ||
|
|
||
| using System; | ||
| using System.Globalization; | ||
| using System.Linq.Expressions; | ||
| using System.Reactive.Disposables; | ||
| using System.Reactive.Linq; | ||
| using System.Reflection; | ||
| using Microsoft.UI.Xaml; | ||
| using Splat; | ||
|
|
||
| #if HAS_UNO | ||
| namespace ReactiveUI.Uno | ||
| #else | ||
| namespace ReactiveUI | ||
| #endif | ||
| { | ||
| /// <summary> | ||
| /// Creates a observable for a property if available that is based on a DependencyProperty. | ||
| /// </summary> | ||
| public class DependencyObjectObservableForProperty : ICreatesObservableForProperty | ||
| { | ||
| /// <inheritdoc/> | ||
| public int GetAffinityForObject(Type type, string propertyName, bool beforeChanged = false) | ||
| { | ||
| if (!typeof(DependencyObject).GetTypeInfo().IsAssignableFrom(type.GetTypeInfo())) | ||
| { | ||
| return 0; | ||
| } | ||
|
|
||
| if (GetDependencyPropertyFetcher(type, propertyName) == null) | ||
| { | ||
| return 0; | ||
| } | ||
|
|
||
| return 6; | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public IObservable<IObservedChange<object, object?>> GetNotificationForProperty(object sender, Expression expression, string propertyName, bool beforeChanged = false, bool suppressWarnings = false) | ||
| { | ||
| if (sender == null) | ||
| { | ||
| throw new ArgumentNullException(nameof(sender)); | ||
| } | ||
|
|
||
| if (sender is not DependencyObject depSender) | ||
| { | ||
| throw new ArgumentException("The sender must be a DependencyObject", nameof(sender)); | ||
| } | ||
|
|
||
| var type = sender.GetType(); | ||
|
|
||
| if (beforeChanged) | ||
| { | ||
| this.Log().Warn( | ||
| CultureInfo.InvariantCulture, | ||
| "Tried to bind DO {0}.{1}, but DPs can't do beforeChanged. Binding as POCO object", | ||
| type.FullName, | ||
| propertyName); | ||
|
|
||
| var ret = new POCOObservableForProperty(); | ||
| return ret.GetNotificationForProperty(sender, expression, propertyName, beforeChanged); | ||
| } | ||
|
|
||
| var dpFetcher = GetDependencyPropertyFetcher(type, propertyName); | ||
| if (dpFetcher == null) | ||
| { | ||
| this.Log().Warn( | ||
| CultureInfo.InvariantCulture, | ||
| "Tried to bind DO {0}.{1}, but DP doesn't exist. Binding as POCO object", | ||
| type.FullName, | ||
| propertyName); | ||
|
|
||
| var ret = new POCOObservableForProperty(); | ||
| return ret.GetNotificationForProperty(sender, expression, propertyName, beforeChanged); | ||
| } | ||
|
|
||
| return Observable.Create<IObservedChange<object, object?>>(subj => | ||
| { | ||
| var handler = new DependencyPropertyChangedCallback((_, _) => | ||
| subj.OnNext(new ObservedChange<object, object?>(sender, expression, default))); | ||
| var dependencyProperty = dpFetcher(); | ||
| var token = depSender.RegisterPropertyChangedCallback(dependencyProperty, handler); | ||
| return Disposable.Create(() => depSender.UnregisterPropertyChangedCallback(dependencyProperty, token)); | ||
| }); | ||
| } | ||
|
|
||
| private static PropertyInfo? ActuallyGetProperty(TypeInfo typeInfo, string propertyName) | ||
| { | ||
| var current = typeInfo; | ||
| while (current != null) | ||
| { | ||
| var ret = current.GetDeclaredProperty(propertyName); | ||
| if (ret?.IsStatic() == true) | ||
| { | ||
| return ret; | ||
| } | ||
|
|
||
| current = current.BaseType?.GetTypeInfo(); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| private static FieldInfo? ActuallyGetField(TypeInfo typeInfo, string propertyName) | ||
| { | ||
| var current = typeInfo; | ||
| while (current != null) | ||
| { | ||
| var ret = current.GetDeclaredField(propertyName); | ||
| if (ret?.IsStatic == true) | ||
| { | ||
| return ret; | ||
| } | ||
|
|
||
| current = current.BaseType?.GetTypeInfo(); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| private static Func<DependencyProperty>? GetDependencyPropertyFetcher(Type type, string propertyName) | ||
| { | ||
| var typeInfo = type.GetTypeInfo(); | ||
|
|
||
| // Look for the DependencyProperty attached to this property name | ||
| var pi = ActuallyGetProperty(typeInfo, propertyName + "Property"); | ||
| if (pi != null) | ||
| { | ||
| var value = pi.GetValue(null); | ||
|
|
||
| if (value is null) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| return () => (DependencyProperty)value; | ||
| } | ||
|
|
||
| var fi = ActuallyGetField(typeInfo, propertyName + "Property"); | ||
| if (fi != null) | ||
| { | ||
| var value = fi.GetValue(null); | ||
|
|
||
| if (value is null) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| return () => (DependencyProperty)value; | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.