-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixing ReactivePage, ReactiveUserControl and DependencyProperties change notification for WinUI 3 #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o, The ReactiveUI.WinUI is getting loaded instead of .net startandard dll.
|
We still have some other changes we want to get done, like adding net 6 support, but these can wait until after your PR is merged in. If you got any other stuff you want to PR might be worth adding a checklist to the winui3 issue so we can coordinate on it. |
|
Yesterday's PR was in error, I wasn't expecting it to be merged so soon. The original PR was based on WinUI preview 3 and since I am bit green with github and forks, I missed couple of things.
Following comes to the mind in terms of what could still be added.
1. Tests, but not sure where to start.
2. Adhoc testing with existing app (but that would happen outside the repo)
3. Since, my code was based on the WPF project, few things are added since then. I am now taking the cue from UWP project and few things are still missing, like `WinRTAppDataDriver`, `AutoSuspendHelper` and `SingleWindowDispatcherScheduler`. `SingleWindowDispatcherScheduler` maybe very specific to UWP and we can skip it. `AutoSuspendHelper` might have to wait, as App life cycle is still in preview in Project ReUnion.
…On Mon, Aug 23, 2021 at 2:57 PM Glenn ***@***.***> wrote:
We still have some other changes we want to get done, like adding net 6
support, but these can wait until after your PR is merged in.
If you got any other stuff you want to PR might be worth adding a
checklist to the winui3 issue so we can coordinate on it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2902 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBJD5SMBZWCRJZXL43QCHDT6HIKVANCNFSM5CTYH42A>
.
|
|
@glennawatson The only issue that I have been able to find is that |
|
We need to probably make a entry for winui3 on the reactiveui.net handbook anyway so will likely be the best location for it. |
|
RxApp.MainThreadScheduler is usually the preferred mechanism anyway since it makes unit tests work better. |
|
@glennawatson Do we have an ETA for the next release? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
The previous PR was not complete, this PR add missing functionality for WinUI
WhenAny*now listens to dependency property changesDispatcheQueueSchedulerWhat might this PR break?
Can't say
Please check if the PR fulfills these requirements
Other information:
ARM64 is still not working, I think it requires
.net 6, not sure