Skip to content

Conversation

@harvinders
Copy link
Contributor

What kind of change does this PR introduce?

The previous PR was not complete, this PR add missing functionality for WinUI

  • adds working ReactivePage and ReactiveUserControl,
  • WhenAny* now listens to dependency property changes
  • ReactiveUI.WinUI library is loaded instead of .net standard version
  • Updated xml document for DispatcheQueueScheduler

What might this PR break?
Can't say

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
ARM64 is still not working, I think it requires .net 6, not sure

@glennawatson
Copy link
Contributor

We still have some other changes we want to get done, like adding net 6 support, but these can wait until after your PR is merged in.

If you got any other stuff you want to PR might be worth adding a checklist to the winui3 issue so we can coordinate on it.

@glennawatson glennawatson merged commit b647a43 into reactiveui:main Aug 23, 2021
@harvinders
Copy link
Contributor Author

harvinders commented Aug 23, 2021 via email

@harvinders
Copy link
Contributor Author

@glennawatson The only issue that I have been able to find is that ObserveOnDispatcher does not work as it resolves to using WPF version in the System.Reactive. It is beyond ReactiveUI and needs to be fixed in there. However, we can still use the alternative ObserveOn(RxApp.MainThreadScheduler). Maybe we can mention it in the release record.

@glennawatson
Copy link
Contributor

We need to probably make a entry for winui3 on the reactiveui.net handbook anyway so will likely be the best location for it.

@glennawatson
Copy link
Contributor

RxApp.MainThreadScheduler is usually the preferred mechanism anyway since it makes unit tests work better.

@harvinders
Copy link
Contributor Author

@glennawatson Do we have an ETA for the next release?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
@harvinders harvinders deleted the feature/winui branch November 24, 2021 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants