Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: RxUI 18.4.26: ObserveOnDispatcher missing #3505

Closed
jasonwurzel opened this issue Mar 24, 2023 · 2 comments · Fixed by #3506
Closed

[Bug]: RxUI 18.4.26: ObserveOnDispatcher missing #3505

jasonwurzel opened this issue Mar 24, 2023 · 2 comments · Fixed by #3506
Labels

Comments

@jasonwurzel
Copy link
Contributor

Describe the bug 🐞

just updated my project from RxUI 18.4.25 to 18.4.26 and got compilation errors, because ObserveOnDispatcher is no longer present.
Project is WPF + net7.0-windows10.0.17763.0

Step to reproduce

  1. git clone https://github.com/jasonwurzel/RxUI_ObserveOnDispatcherMissing
  2. main branch compiles
  3. switch to updated_rxui branch
  4. compile errors

Reproduction repository

https://github.com/jasonwurzel/RxUI_ObserveOnDispatcherMissing

Expected behavior

There should be no breaking change updating from 18.4.25 to 18.4.26

Screenshots 🖼️

No response

IDE

No response

Operating system

Windows 11

Version

No response

Device

No response

ReactiveUI Version

18.4.26

Additional information ℹ️

Looking at the only change that happened in #3497 , it is totally logical because of this section in ReactiveUI.Wpf.csproj:

  <ItemGroup Condition=" $(TargetFramework) == 'net462' or $(TargetFramework.StartsWith('net6.0-windows')) or $(TargetFramework.StartsWith('net7.0-windows')) ">
    <Compile Include="..\ReactiveUI.Uwp\Rx\Internal\Constants.cs" LinkBase="Rx" />
    <Compile Include="..\ReactiveUI.Uwp\Rx\Linq\**\*.cs" LinkBase="Rx" Exclude="..\ReactiveUI.Uwp\Rx\Linq\*Observable.cs" />
  </ItemGroup>

That means the static class named DispatcherObservable containing SubscribeOnDispatcher is no longer included.
Or am I missing something here?

@jasonwurzel
Copy link
Contributor Author

( upgrading the TFM to net7.0-windows10.0.19041.0 fixes it, guess that is the most efficient way to get rid of the error )

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant