Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DispatcherScheduler issue with ObserveOn #3497

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix for #3495

What is the current behaviour?

Targeting windows10.0.19041.0 exposes System.Reactive base functionality causing issues with ReactiveUI

What is the new behaviour?

When targeting windows10.0.19041.0 ReactiveUI uses System.Reactive base functionality

What might this PR break?

None expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson enabled auto-merge (squash) March 11, 2023 11:05
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.51 🎉

Comparison is base (e666feb) 63.83% compared to head (e755263) 64.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
+ Coverage   63.83%   64.34%   +0.51%     
==========================================
  Files         157      156       -1     
  Lines        5768     5702      -66     
==========================================
- Hits         3682     3669      -13     
+ Misses       2086     2033      -53     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glennawatson glennawatson merged commit b49c311 into main Mar 11, 2023
@glennawatson glennawatson deleted the FixObserveOnSubscribeOn10.0.19041.0 branch March 11, 2023 11:35
@FRANKAAAA67

This comment was marked as spam.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants