style: tidy up comments for ReactiveBinding and command binding #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcb
reviewed
Feb 8, 2017
| @@ -18,7 +18,7 @@ public interface IReactiveBinding<TView, TViewModel, TValue> : IDisposable | |||
| where TView : IViewFor | |||
| { | |||
| /// <summary> | |||
| /// The instance of the view model this binding is applied to.</param> | |||
kentcb
approved these changes
Feb 8, 2017
| @@ -150,9 +141,6 @@ internal class ReactiveBinding<TView, TViewModel, TValue> : IReactiveBinding<TVi | |||
| /// </value> | |||
| public BindingDirection Direction { get; private set; } | |||
|
|
|||
| /// <summary> | |||
| /// Releases unmanaged and - optionally - managed resources. | |||
| /// </summary> | |||
| public void Dispose() | |||
There was a problem hiding this comment.
Wow, where did this originate from? Looks like some incredibly useful ghostdoc vomit.
There was a problem hiding this comment.
I don't really know...it seemed a bit like stating the obvious. To be honest, I'm not sure any of these comments make sense on the internal implementation of the fairly well commented interface...
There was a problem hiding this comment.
GhostDoc noise can burn in a pit of 🔥
ghuntley
approved these changes
Feb 8, 2017
| @@ -150,9 +141,6 @@ internal class ReactiveBinding<TView, TViewModel, TValue> : IReactiveBinding<TVi | |||
| /// </value> | |||
| public BindingDirection Direction { get; private set; } | |||
|
|
|||
| /// <summary> | |||
| /// Releases unmanaged and - optionally - managed resources. | |||
| /// </summary> | |||
| public void Dispose() | |||
There was a problem hiding this comment.
GhostDoc noise can burn in a pit of 🔥
ghuntley
changed the title
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Tidying comments in a couple of binding related files.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: