New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: tidy up comments for ReactiveBinding and command binding #1267
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ public interface IReactiveBinding<TView, TViewModel, TValue> : IDisposable | |
where TView : IViewFor | ||
{ | ||
/// <summary> | ||
/// The instance of the view model this binding is applied to.</param> | ||
/// The instance of the view model this binding is applied to. | ||
/// </summary> | ||
/// <value> | ||
/// The view model. | ||
|
@@ -76,15 +76,6 @@ internal class ReactiveBinding<TView, TViewModel, TValue> : IReactiveBinding<TVi | |
{ | ||
private IDisposable bindingDisposable; | ||
|
||
/// <summary> | ||
/// Initializes a new instance of the <see cref="AppliedBindingInfo{TViewModel}" /> class. | ||
/// </summary> | ||
/// <param name="view">The view.</param> | ||
/// <param name="viewModel">The view model.</param> | ||
/// <param name="viewPath">The view path.</param> | ||
/// <param name="viewModelPath">The view model path.</param> | ||
/// <param name="direction">The direction.</param> | ||
/// <param name="bindingDisposable">The binding disposable.</param> | ||
public ReactiveBinding(TView view, TViewModel viewModel, Expression viewExpression, Expression viewModelExpression, | ||
IObservable<TValue> changed, BindingDirection direction, IDisposable bindingDisposable) | ||
{ | ||
|
@@ -99,7 +90,7 @@ internal class ReactiveBinding<TView, TViewModel, TValue> : IReactiveBinding<TVi | |
} | ||
|
||
/// <summary> | ||
/// The instance of the view model this binding is applied to.</param> | ||
/// The instance of the view model this binding is applied to. | ||
/// </summary> | ||
/// <value> | ||
/// The view model. | ||
|
@@ -150,9 +141,6 @@ internal class ReactiveBinding<TView, TViewModel, TValue> : IReactiveBinding<TVi | |
/// </value> | ||
public BindingDirection Direction { get; private set; } | ||
|
||
/// <summary> | ||
/// Releases unmanaged and - optionally - managed resources. | ||
/// </summary> | ||
public void Dispose() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wow, where did this originate from? Looks like some incredibly useful ghostdoc vomit. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really know...it seemed a bit like stating the obvious. To be honest, I'm not sure any of these comments make sense on the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GhostDoc noise can burn in a pit of 🔥 |
||
{ | ||
if (bindingDisposable != null) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lolwat - good catch!