docs: upgraded version of xam forms and changed ondestroy to use flush instead of shutdown #1506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix and upgraded xamarin forms version
What is the current behavior? (You can also link to an open issue here)
Currently in OnDestroy on the MainActivity it was calling BlobCache.Shutdown which completely shuts down the cache from ever being used again. In cases where the MainActivity is destroyed but static things stay in memory this caused the app to stop working.
you could recreate by
What is the new behavior (if this is a feature change)?
Here's a longer discussion about this
reactiveui/Akavache#342
As an example it'd probably be good to just not use LocalMAchine all together but this works for now
What might this PR break?
Please check if the PR fulfills these requirements
Other information: