fix: several ReactiveCommand bugs #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kentcb, |
|
I've merged this locally and can confirm this fixes #1476. 👍 |
kentcb
force-pushed
the
invoke-command
branch
from
a2c0edb
to
530d409
Compare
|
I meant to link to the related Rx issue. |
|
Thanks for confirming @Qonstrukt! I've rebased the branch on top of your Xamarin.Android fixes and will hopefully get it merged a bit later today. Reviews welcome! |
kentcb
force-pushed
the
invoke-command
branch
2 times, most recently
from
f6d7ab8
to
da42ed1
Compare
kentcb
force-pushed
the
invoke-command
branch
from
da42ed1
to
abb841d
Compare
|
Changes Unknown when pulling abb841d on kentcb:invoke-command into ** on reactiveui:develop**. |
kentcb
changed the title
olevett
approved these changes
Nov 11, 2017
|
Thanks for the review @olevett |
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
fix: several ReactiveCommand bugs (#1534) * Use custom WithLatestFrom implementation that bypasses unexpected behavior in the operator provided by Rx, thereby fixing InvokeCommand scenarios in which the source is cold or primed. * Support multiple, in-flight executions correctly. * Correctly handle disposal of an in-flight execution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fixes
What is the current behavior? (You can also link to an open issue here)
InvokeCommandrelies on Rx'sWithLatestFromoperator, which is...weird. It subscribes to first observable first, and then the second, which can result in missing values.What is the new behavior (if this is a feature change)?
InvokeCommandrelies on our own customWithLatestFromFixedoperator, which publishes the source observable so values aren't missed.IsExecutingandCanExecutereport intuitive values.What might this PR break?
Nothing - it should fix several scenarios.
Please check if the PR fulfills these requirements
Other information: