Added git hash to AssemblyInformationVersion #1560
Conversation
|
Changes Unknown when pulling 779885d on RLittlesII:GH1515 into ** on reactiveui:develop**. |
There was a problem hiding this comment.
Nice, thanks for this.
Not sure if you've looked at and discounted this, but I think GitVersion includes an InformationalVersion that can be configured
(https://gitversion.readthedocs.io/en/latest/configuration/) out of any of the variables available here, so we could push this down to GitVersion rather than Cake. I think we'd still need the MSBuild property to be set though, so that may not be any neater.
|
@olevett I'll take a look at it this weekend, and see if that is a cleaner solution. |
|
Changes Unknown when pulling 31e208b on RLittlesII:GH1515 into ** on reactiveui:develop**. |
Added informational version format to GitVersion config
|
Changes Unknown when pulling 178f718 on RLittlesII:GH1515 into ** on reactiveui:develop**. |
|
Looks good to me, thanks :) |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds the git commit sha to the Product Version on ReactiveUI dll's.
What is the current behavior? (You can also link to an open issue here)
fixes #1515
What is the new behavior (if this is a feature change)?
When viewing the Properties -> Details of any ReactiveUI dll you will be able to see the first 8 characters of the git commit hash in the Product Version field.
What might this PR break?
Shouldn't break anything, it is an isolated change to the output of the nuget package dll's.
Please check if the PR fulfills these requirements
Other information:
@ghuntley was concerned about the legacy dll's being different. It seems that they are working. ReactiveUI.WPF and ReactiveUI.Events.WPF both seem to have the new commit hash without the need to do anything different.