Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: move editorconfig to a single location #1605

Merged
merged 2 commits into from
May 12, 2018
Merged

Conversation

olevett
Copy link
Member

@olevett olevett commented May 1, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature, I guess

What is the current behavior? (You can also link to an open issue here)

we have a couple of editor configs that are the same for samples and code

What is the new behavior (if this is a feature change)?

we have one single editorconfig for everything

What might this PR break?

Nothing.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

since having two copies seems a bit silly, and this will cover e.g. integration tests

since having two copies seems a bit silly, and this will cover e.g. integration tests
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.257% when pulling b11d59b on editorconfig into 581b959 on develop.

@ghuntley ghuntley changed the base branch from develop to master May 11, 2018 23:54
@ghuntley ghuntley self-requested a review May 11, 2018 23:59
@ghuntley ghuntley merged commit f4083c6 into master May 12, 2018
@ghuntley ghuntley deleted the editorconfig branch May 12, 2018 00:06
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
since having two copies seems a bit silly, and this will cover e.g. integration tests
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants