housekeeping: Fix typos and broken links in readme #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add links to documentation, reduce empty space
glennawatson
approved these changes
Aug 5, 2018
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
* housekeeping: Fix typos and broken links in readme Add links to documentation, reduce empty space * housekeeping: add fancy emojis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Changes in README.md to make it more friendly to new users.
What is the current behavior? (You can also link to an open issue here)
There are some images not displaying due to broken urls, there are no links to documentation or to "Getting Started" page in old README.md file.
What is the new behavior (if this is a feature change)?
Images are back in town, links to docs, packages and samples are also added. "A Compelling Example" now uses
WhenAnyValueinstead ofWhenAnyandx.Value, curly brackets are formatted using .NET Core code of conduct.What might this PR break?
Nothing, really.
Other information:
Personally I don't like centered text and huge empty space caused by "Table of Contents", so I removed these things.