-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add winforms auto binding to Tables/Flow based controls #1956
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
- Coverage 59.01% 58.38% -0.64%
==========================================
Files 117 120 +3
Lines 4780 4803 +23
Branches 678 689 +11
==========================================
- Hits 2821 2804 -17
- Misses 1786 1822 +36
- Partials 173 177 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; nice simplifications and cleanup.
Hi there @glennawatson @gpriaulx! Thank you for the work on ReactiveUI it is great! :) This commit unfortunately breaks some functionality. If a property value of a binding was null, the framework could (in v9.10.7) cleanly convert it into something appropriate. Example: this.WhenActivated(disposable =>
{
this.WhenAnyValue(x => x.FormText)
.BindTo(this, x => x.Text)
.DisposeWith(disposable);
}); Please note that
|
It's worth probably taking this sort of feedback straight to an issue btw. Closed PR's have a habit of getting lost. Moved it over to one ;) |
The following has been added:
ISetMethodBindingConverter
which allows the bind engine to perform a custom set operation. This is because WinForms often gives you collections where you are meant to do 'Add' operations directly rather than setting them.ISetMethodBindingConverter
. One for general ContentControls, the other for tables.