Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow uno namespace for uap17.0.17763 #2099

Merged
merged 1 commit into from Jun 29, 2019

Conversation

Projects
None yet
1 participant
@glennawatson
Copy link
Contributor

commented Jun 29, 2019

Based on PR from @weitzhandler with some additional changes to make it compile.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Jun 29, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 29, 2019

Codecov Report

Merging #2099 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2099   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files         117      117           
  Lines        4614     4614           
  Branches      718      718           
=======================================
  Hits         2679     2679           
  Misses       1712     1712           
  Partials      223      223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6846fb1...155ad45. Read the comment docs.

@glennawatson glennawatson merged commit 2089f59 into master Jun 29, 2019

6 checks passed

ReactiveUI-CI Build #9.18.3+6864fbd197 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing 6846fb1...155ad45
Details
codecov/project 58.06% remains the same compared to 6846fb1
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-uno-namespace-issues branch Jun 29, 2019

madmonkey added a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.