Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fatal exception "Element not found" in UWP multiple views apps #2215

Merged
merged 3 commits into from Oct 15, 2019

Conversation

@KAS1990
Copy link
Contributor

KAS1990 commented Oct 15, 2019

1 Check _dispatcher has been initialized to prevent always calling CoreApplication.Views[0].Dispatcher
2 Wrapped Interlocked.CompareExchange by try...catch to call standard exception handler

What kind of change does this PR introduce?
It is bugfix and fixes #2188

What is the current behavior?
#2188

What is the new behavior?
App is not crashing on getting the first app view dispatcher in multiple views apps.

KAS1990 added 2 commits Oct 15, 2019
…reApplication.Views[0].Dispatcher

2 Wrapped Interlocked.CompareExchange by try...catch to call standard exception handler
Exceptions in Interlocked.CompareExchange will be ignored.
@KAS1990 KAS1990 requested a review from reactiveui/core-team as a code owner Oct 15, 2019
@glennawatson glennawatson changed the title Fixing fatal exception "Element not found" in multiple views apps Fix: fatal exception "Element not found" in multiple views apps Oct 15, 2019
@glennawatson glennawatson changed the title Fix: fatal exception "Element not found" in multiple views apps Fix: fatal exception "Element not found" in UWP multiple views apps Oct 15, 2019
@glennawatson glennawatson merged commit 77e160a into reactiveui:master Oct 15, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #10.5.9+c7774f8c22 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.