Fix: fatal exception "Element not found" in UWP multiple views apps #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reApplication.Views[0].Dispatcher 2 Wrapped Interlocked.CompareExchange by try...catch to call standard exception handler
Exceptions in Interlocked.CompareExchange will be ignored.
glennawatson
changed the title
glennawatson
changed the title
glennawatson
approved these changes
Oct 15, 2019
|
Hi, any news on when a new version containing this fix will be released on nuget? |
|
Should already have been released a while back. |
|
https://github.com/reactiveui/ReactiveUI/releases/tag/10.5.6
|
|
oh, thanks. That is strange, then maybe something is messed up on my machine...thanks for the info |
|
ok, found the cause. The fix #2215 changed the logic in "ScheduleOnDispatcherNow", but not in the classes ctor. Thus the exception still is thrown when SingleWindowDispatcherScheduler is constructed. I'll try to make a PR. |
|
My app has not been crashed after this update. Bug fixed. Thank you |
|
I think this was a misunderstanding. I was talking about the bug #2154 that suposedly got fixed with this merge (which isn't). So I'll try to fix it :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Check _dispatcher has been initialized to prevent always calling CoreApplication.Views[0].Dispatcher
2 Wrapped Interlocked.CompareExchange by try...catch to call standard exception handler
What kind of change does this PR introduce?
It is bugfix and fixes #2188
What is the current behavior?
#2188
What is the new behavior?
App is not crashing on getting the first app view dispatcher in multiple views apps.