-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add ReactiveUI.Maui #2879
Conversation
adding ReactiveUI.Events.Maui wild car the Maui preview version
@@ -1,6 +1,6 @@ | |||
<Project Sdk="MSBuild.Sdk.Extras"> | |||
<PropertyGroup> | |||
<TargetFrameworks>netstandard2.0;net5.0;Xamarin.iOS10;Xamarin.Mac20;Xamarin.TVOS10;MonoAndroid10.0;tizen40</TargetFrameworks> | |||
<TargetFrameworks>netstandard2.0;net5.0;Xamarin.iOS10;Xamarin.Mac20;Xamarin.TVOS10;MonoAndroid10.0;tizen40;net6.0</TargetFrameworks> | |||
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net461;net472;uap10.0.16299;netcoreapp3.1;net5.0-windows;net5.0-windows10.0.19041</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before next major goes out I think we need to remove our uap/net5.0-windows etc targets, might mean we move uap out into its own package but i'm fine with that.
This should use conversionHint to determine whether this is locale-aware or not
This comment was generated by todo based on a
|
cc8a71f
to
d34f906
Compare
remove from solution remove project
d34f906
to
2102548
Compare
Codecov Report
@@ Coverage Diff @@
## main #2879 +/- ##
=======================================
Coverage 71.95% 71.96%
=======================================
Files 144 144
Lines 5007 5008 +1
=======================================
+ Hits 3603 3604 +1
Misses 1404 1404
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
adding ReactiveUI.Events.Maui
wild car the Maui preview version
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
What might this PR break?
Please check if the PR fulfills these requirements
Other information: