Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping - Update Spelling and minor code fixes #3649

Merged
merged 4 commits into from Oct 31, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Update

What is the current behavior?

Code has spelling errors

What is the new behavior?

Fixed ReactiveUI main project spelling

What might this PR break?

none expected

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0a61f2a) 64.07% compared to head (716d1de) 58.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   64.07%   58.58%   -5.49%     
==========================================
  Files         158      158              
  Lines        5762     5829      +67     
  Branches        0     1030    +1030     
==========================================
- Hits         3692     3415     -277     
+ Misses       2070     2030      -40     
- Partials        0      384     +384     
Files Coverage Δ
...rc/ReactiveUI.Winforms/ActivationForViewFetcher.cs 67.44% <ø> (-6.98%) ⬇️
...activeUI.Winforms/CreatesWinformsCommandBinding.cs 87.03% <ø> (-7.41%) ⬇️
...rvableCollectionChangedToListChangedTransformer.cs 0.00% <ø> (ø)
src/ReactiveUI.Winforms/ReactiveUserControl.cs 37.50% <ø> (-12.50%) ⬇️
src/ReactiveUI.Winforms/RoutedViewHost.cs 86.84% <ø> (-5.27%) ⬇️
src/ReactiveUI.Winforms/ViewModelViewHost.cs 90.19% <ø> (-2.95%) ⬇️
...I.Winforms/WinformsCreatesObservableForProperty.cs 74.28% <ø> (-8.58%) ⬇️
...iveUI.Wpf/DependencyObjectObservableForProperty.cs 64.28% <ø> (-10.72%) ⬇️
...rc/ReactiveUI.XamForms/ActivationForViewFetcher.cs 44.11% <ø> (-4.91%) ⬇️
src/ReactiveUI.XamForms/RoutedViewHost.cs 93.18% <ø> (-3.98%) ⬇️
... and 26 more

... and 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson merged commit f6bdee0 into main Oct 31, 2023
2 of 3 checks passed
@glennawatson glennawatson deleted the CP_SpellingAndMinorCodeUpdates branch October 31, 2023 20:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants