Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping Update Build to use dotnet build #3799

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Housekeeping Update Build to use dotnet build #3799

merged 3 commits into from
Apr 30, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Update build script

What is the current behavior?

using MsBuild

What is the new behavior?

using DotNet Build

What might this PR break?

none expected

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman marked this pull request as draft April 30, 2024 00:21
@ChrisPulman ChrisPulman marked this pull request as ready for review April 30, 2024 00:58
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.204",
"version": "8.0.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am i missing something with .10? that's a pre release version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"rollForward": "latestMinor" brings it to the latest available, I have had issues with using the latest version as sometimes even though its released the Github Build server fails to get it causing failure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we just specified "version": "8.0" this caused an issue when using DotNet Build, MsBuild doesnt care and all is well, now that we are switching away from MsBuild its more important. "version": "8.0.10" is enough detail for it to be happy and roll forward

@dpvreony dpvreony merged commit a31490e into main Apr 30, 2024
1 check passed
@dpvreony dpvreony deleted the UpdateBuild branch April 30, 2024 23:36
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants