Ship ReactiveUI 6.0 #434

anaisbetts · 2013-12-12T19:05:21Z

ReactiveUI 6.x is now in Ship It Mode, the :squirrel: must be given its Due.

DO THIS BEFORE SHIPPING

Consider rewriting ReactiveCommand still.
Need to make Android Support into a separate lib, it conflicts too much with other stuff (/cc @onovotny) (Need to make Android Support into a separate lib, it conflicts too much with other stuff #571)
Suspend / Resume is mostly weird and broken on multiple platforms (Fix or remove ReactiveUI.Mobile #570)
Whatever gets announced at BUILD, we're this close already, may as well ([WIP] Universal App support. #552)
Wait for Rx.NET to include Profile259. (Integrate Rx vNext #569)

What has Shipped:

Fix up collection interfaces (Improve interfaces for reactive collections. #432)
Xamarin moves to PCLs (Portable ReactiveUI.dll, even on Xamarin #438)
ReactiveUI is now based on Splat (Use Splat to provide features previously done in ReactiveUI #451)
Nuke legacy ReactiveCommands (ty @jlaanstra)
Remove IO as an interface from OAPH (ty @niik)
Move service location + logging + unit test detection to Splat, make ReactiveUI depend on it, so that Akavache doesn't need ReactiveUI and everyone can share service location / logging without buying into RxUI
Ship 6.0 Alpha
Attach CanExecute to Bound Commands on iOS (Attach CanExecute to bound commands #469)
Add ReactiveListAdapter, Android binding improvements (Android-specific enhancements for RxUI 6 #470)
ViewPager adapter (Add support for binding a ReactiveList to a ViewPager control #494)
Add Blend for Windows 8.1 (ReactiveUI.Blend for Windows 8.1. #487)
Remove scheduling (No more scheduling + Lazy ToProperty #516)
Rewritten ReactiveCommand (Rewrite ReactiveCommand #521)
Activation framework (View / ViewModel Activation #503, Only activate views when they are hit test visible. #526)
Asynchronous intent results on Android (Async intent result #528)
Reactive subclasses for many more Cocoa objects
Event leak fixes on XAML-based platforms (Fix memory leaks with events. #547, Remove Dependency Property binding when disposing. #549)
Generic Cocoa classes for collection and table view sources (RxUI6: Additional interfaces cleanup #448)
Make sure people who naively await events don't deadlock (Make events do The Right Thing automatically when awaited #586)
Move ReactiveUI to a single DLL (Rename Create overloads in ReactiveCommand #587)
Cocoa scheduler now runs items sequentially on the UI thread (Fix the NSRunloopScheduler to just run the action if it can #600)
WinForms view caching (Add caching option to ViewModelViewHost in winforms to improve performance #603)

Breaking Changes

Anything dependending on the non-generic IReactiveCollection. I believe you can just use the generic variant almost everywhere, since every collection type in ReactiveUI is generic.
Anything implementing IReactiveCollection<T> only loses the type IReactiveCollection. All its interfaces are still implemented by the generic variant.
The IReactiveCollection<T> interface no longer implements ICollection<T>. However it does still implement IEnumerable<T>.
ReactiveUI now depends on the Microsoft version of Rx, version 2.2.2
IEnableLogger now needs a using Splat;
InitializeResolver => InitializeSplat + InitializeReactiveUI
Legacy ReactiveUI 4.x commands are gone - pull them from source if you need them
ObservableAsPropertyHelper is now no longer directly IObservable. Use WhenAny to get to these properties instead of grabbing the backing field.
MemoizingMRUCache and ObservableAsyncMRUCache are both removed - the former has moved to Splat (add a using Splat; to fix this), and the latter is deprecated. Akavache is a better solution for ObservableAsyncMRUCache.
ReactiveUI now no longer implicitly schedules things to the UI thread for you except for RegisterAsync. If you were relying on this, you probably need to add some ObserveOn(RxApp.MainThreadScheduler)s
ReactiveCommand is a lot different. See Rewrite ReactiveCommand #521 for more.
ReactiveUI on iOS now requires Xamarin.iOS 7.2.1 or higher
No more references to ReactiveUI.Platforms - NuGet should handle this Automagically

Find And Replace Breaking Changes

RxApp.DependencyResolver => Locator.Current
RxApp.MutableResolver => Locator.CurrentMutable
RxApp.InUnitTestRunner => ModeDetector.InUnitTestRunner

tberman · 2013-12-13T15:42:12Z

I have found the non generic versions to be very useful. For example, assume you have a method called GetEvents(some params) and it returns collections of various types based on those params, being able to address that return value as a non-generic collection can be very valuable.

clairernovotny · 2013-12-14T00:16:45Z

What would you say is the current status for RxUI 6? I saw that there was the breaking IReactiveCollection interface removal, which is cool, but what generally is planned for it?

Any removal of some of the legacy stuff -- having too many different ways of doing the same thing?

With the Xamarin hotfix, do you think the rxui6-master branch is "stable/correct" for use or has there been too much untested code put in?

Must kill file-linked projects! :)

anaisbetts · 2013-12-16T00:43:45Z

@jlaanstra Thanks for the fixups - how did I miss this? Weird.

anaisbetts · 2013-12-16T00:44:28Z

ReactiveCollectionView for Windows Runtime to do grouping, lazy loading, etc

👍

jlaanstra · 2013-12-16T13:29:36Z

I have found the non generic versions to be very useful. For example, assume you have a method called GetEvents(some params) and it returns collections of various types based on those params, being able to address that return value as a non-generic collection can be very valuable.

You should still be able to do this by using ISomeInterface, which is basically the same as a non-generic interface.

jlaanstra · 2013-12-16T13:32:32Z

Any removal of some of the legacy stuff -- having too many different ways of doing the same thing?

I would say +1 to removing the legacy stuff that currently resides in the Legacy folder, but I leave that decision to @paulcbetts .

tberman · 2013-12-16T17:30:28Z

@jlaanstra What is ISomeInterface? The issue is I want IReactiveCollection for sure, not IList or something that doesn't have the same interface guarantees.

anaisbetts · 2013-12-18T03:24:09Z

Hey guys, there was a screwed up merge awhile back and I had to rewrite history to fix it - if you pulled sometime this afternoon, you need to do the following to fix it:

git fetch
git reset origin/rxui6-master

clairernovotny · 2013-12-18T03:30:24Z

I just did that - I also nuked my local rxui6-master branch and re-checked it out from the origin (upstream in my remotes)

When I try to push back to my fork I get the following error:

error: failed to push some refs to 'https://onovotny@github.com/onovotny/ReactiveUI.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

How do I force the push to my fork?

anaisbetts · 2013-12-18T04:50:41Z

@onovotny git push -f [your fork remote name] rxui6-master

clairernovotny · 2014-01-05T22:39:14Z

Just noticed that in the interface refactoring/cleanup, SuppressChangeNotifications() is no longer on the base interfaces for IReactiveList. It should go back...

clairernovotny · 2014-01-06T18:44:05Z

For a To Do: Need to figure out if Bind(*) can work without the IViewFor constraint.

The scenario is Android, in the views for reactive list adapters. If you try to bind to a simple view, like TextView, there's no way to. You need to derive your own to get IViewFor.

jlaanstra · 2014-01-12T18:24:10Z

•Windows 8.0 is no longer supported

I would like to add this back. Windows 8 still has twice as much market share as Windows 8.1 according to Net Applications (http://thenextweb.com/insider/2014/01/01/windows-8-windows-8-1-pass-10-market-share-windows-7-still-gains-windows-xp-falls-30/#!r1NYr) and since we currently do not use Windows 8.1 specific API's, I do not see a good reason to drop Win8 support in RxUI 6.x.

I will submit a PR but would like to hear your opinions first. Note that a library targeting Windows 8 will run just fine on Windows 8.1

anaisbetts · 2014-01-12T19:48:21Z

I do not see a good reason to drop Win8 support in RxUI 6.x.

I can't even create Win8.0 projects in VS2013 anymore, and I'm constantly nagged by VS to upgrade them. I'd rather just capitulate.

Hm. However, 50% of WinRT-capable people still on Win8 is a compelling argument. Anyone else have any thoughts?

jlaanstra · 2014-01-12T21:18:06Z

I can't even create Win8.0 projects in VS2013 anymore, and I'm constantly nagged by VS to upgrade them. I'd rather just capitulate.

VS only prompts you once unless you remove the .suo file. I don't like it too but I just ignore it and while creating the projects seems like a hassle, you can still build and maintain them if you choose to install the VS part during setup.

I would love to be able to do Win81 only, but with the current adoption I just still need Win8 support and I guess many others do too.

jlaanstra · 2014-01-12T21:22:46Z

I will create a PR with the projects setup correctly.

anaisbetts · 2014-02-17T03:43:54Z

Here's a backup copy of what was the Ideas thread before we transitioned into mode:

This branch is the Master branch for tracking all of the stuff that will eventually become ReactiveUI 6.0:

Cool Ideas

Rewrite ReactiveCommand to match what ReactiveCocoa does in 3.0 (just for you @jspahrsummers)
Actually make good on the scaffolding promises made in 5.x
ReactiveCollectionView for Windows Runtime to do grouping, lazy loading, etc (@jlaanstra)
Redacted Xamarin Project (NOT TELLING)
Keyboard Navigation (Jotting some ideas down around keyboard navigation #404)
View / ViewModel Activation

What has Shipped:

Fix up collection interfaces (Improve interfaces for reactive collections. #432)
Xamarin moves to PCLs (Portable ReactiveUI.dll, even on Xamarin #438)
ReactiveUI is now based on Splat (Use Splat to provide features previously done in ReactiveUI #451)
Nuke legacy ReactiveCommands (ty @jlaanstra)
Remove IO as an interface from OAPH (ty @niik)
Move service location + logging + unit test detection to Splat, make ReactiveUI depend on it, so that Akavache doesn't need ReactiveUI and everyone can share service location / logging without buying into RxUI
Ship 6.0 Alpha
Attach CanExecute to Bound Commands on iOS (Attach CanExecute to bound commands #469)
Add ReactiveListAdapter, Android binding improvements (Android-specific enhancements for RxUI 6 #470)
ViewPager adapter (Add support for binding a ReactiveList to a ViewPager control #494)
Add Blend for Windows 8.1 (ReactiveUI.Blend for Windows 8.1. #487)
Remove scheduling (No more scheduling + Lazy ToProperty #516)

Breaking Changes

Anything dependending on the non-generic IReactiveCollection. I believe you can just use the generic variant almost everywhere, since every collection type in ReactiveUI is generic.
Anything implementing IReactiveCollection<T> only loses the type IReactiveCollection. All its interfaces are still implemented by the generic variant.
The IReactiveCollection<T> interface no longer implements ICollection<T>. However it does still implement IEnumerable<T>.
ReactiveUI now depends on the Microsoft version of Rx, version 2.2.2
IEnableLogger now needs a using Splat;
InitializeResolver => InitializeSplat + InitializeReactiveUI
Legacy ReactiveUI 4.x commands are gone - pull them from source if you need them
ObservableAsPropertyHelper is now no longer directly IObservable. Use WhenAny to get to these properties instead of grabbing the backing field.
MemoizingMRUCache and ObservableAsyncMRUCache are both removed - the former has moved to Splat (add a using Splat; to fix this), and the latter is deprecated. Akavache is a better solution for ObservableAsyncMRUCache.
ReactiveUI now no longer implicitly schedules things to the UI thread for you except for RegisterAsync. If you were relying on this, you probably need to add some ObserveOn(RxApp.MainThreadScheduler)s

DO THIS BEFORE SHIPPING

Update the Android package to depend on the Xamarin Support Lib
Suspend / Resume is mostly weird and broken on multiple platforms
Still hitting bugs around not being initialized because DependencyResolver moved to Splat
Need to make Android Support into a separate lib, it conflicts too much with other stuff (/cc @onovotny)

Find And Replace Breaking Changes

RxApp.DependencyResolver => Locator.Current
RxApp.MutableResolver => Locator.CurrentMutable
RxApp.InUnitTestRunner => ModeDetector.InUnitTestRunner

clairernovotny · 2014-04-01T16:02:35Z

The changes to RxUI.Cocoa where there were generic NSObjects should be restored. Xamarin.iOS 7.2.1 finally supports generic NSObjects!

http://docs.xamarin.com/guides/ios/under_the_hood/api_design/nsobject_generics/

clairernovotny · 2014-04-01T16:09:33Z

Hmm....seems @paulcbetts has already reverted it. 🍻

…inking

Fix incorrect passing of Lambda expression.

Object.Prop1 changes Object.Prop1 is being listened for changes, and when Prop1 changes, it causes Prop2 to change Object.Prop2 change listener doesn't fire properly (it is caught in the buffer) This is because the way Buffer is implemented internally, it Nexts out the buffer, then re-grabs the Close observable, so any changes created during that window are stuck until the buffer gets closed next time.

Fix nested object change

Proxy BinarySearch methods to inner list

…docs

Throttle values until the command can again be executed.

Intellisense docs

Ship ReactiveUI 6.0

shiftkey · 2014-07-07T06:44:56Z

jen20 · 2014-07-07T08:21:24Z

👍

ammeep · 2014-07-09T14:19:32Z

💥 💃

This was referenced Jan 16, 2014

ReactiveUI.Mobile ref's the wrong Json.net for 6.0 #476

Closed

Android: When SDK-linking is enabled (release builds), types throw #477

Closed

This was referenced Jan 16, 2014

iOS: Need a ReactiveUIPickerViewModel for UIPickerView's #488

Closed

ControlFetcherMixIn doesn't work with support lib views #491

Closed

JakeGinnivan mentioned this pull request Apr 16, 2014

How to support pre-release in GitHubFlow GitTools/GitVersion#145

Closed

anaisbetts added 6 commits May 23, 2014 13:43

Rig Playground-Android to test suspension stuff, update it

6f2616e

Actually create a SuspensionHost

40148e0

This code has always been wrong and broken what in the world was I th…

56b1805

…inking

Update Playground

1078211

Finally get something working on Android

a4f9ae4

Actually initialize that app class

f9d469e

anaisbetts and others added 23 commits June 20, 2014 16:18

Make sure we only kick things off on first delay

bbb1ebd

Merge branch 'add_delay_change_notifications_to_RO' into rxui6-master

db2d234

Fix incorrect passing of expression.

e2bcdd2

Merge pull request #648 from reactiveui/fix-onewaybind-bug

02b98e8

Fix incorrect passing of Lambda expression.

Much cleaner fix, that still allows the publish/refcount

0cf6b80

Merge pull request #649 from reactiveui/fix_nested_object_change

05ace60

Fix nested object change

Proxy BinarySearch methods to inner list

2a27989

Merge pull request #650 from reactiveui/reactivelist-binarysearch-proxy

b8883b6

Proxy BinarySearch methods to inner list

Stub more docs

970b37d

Merge remote-tracking branch 'origin/rxui6-master' into intellisense-…

02ba113

…docs

Document Activation

e03b619

Dox AutoPersistHelper

ac221df

Misc dox

dc1571c

Do all of ReactiveCommand

8a71bbb

Finish up documenting RxUI Core

dedbabc

Throttle values until the command can again be executed.

8588156

Remove unnecessary Select

61eccd3

CanExecuteChanged already fires on the UI. Start with current value.

7c837cc

Merge pull request #654 from reactiveui/throttle-invokecommand

c7bc0a0

Throttle values until the command can again be executed.

Document new Android classes

dae2b76

Dox the Cocoa classes

145cd4f

Merge pull request #653 from reactiveui/intellisense-docs

a8ce472

Intellisense docs

anaisbetts pushed a commit that referenced this pull request Jul 7, 2014

Merge pull request #434 from reactiveui/rxui6-master

4802adc

Ship ReactiveUI 6.0

anaisbetts merged commit 4802adc into master Jul 7, 2014

ghuntley deleted the rxui6-master branch August 14, 2017 09:06

lock bot locked and limited conversation to collaborators Jun 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ship ReactiveUI 6.0 #434

Ship ReactiveUI 6.0 #434

anaisbetts commented Dec 12, 2013

tberman commented Dec 13, 2013

clairernovotny commented Dec 14, 2013

anaisbetts commented Dec 16, 2013

anaisbetts commented Dec 16, 2013

jlaanstra commented Dec 16, 2013

jlaanstra commented Dec 16, 2013

tberman commented Dec 16, 2013

anaisbetts commented Dec 18, 2013

clairernovotny commented Dec 18, 2013

anaisbetts commented Dec 18, 2013

clairernovotny commented Jan 5, 2014

clairernovotny commented Jan 6, 2014

jlaanstra commented Jan 12, 2014

anaisbetts commented Jan 12, 2014

jlaanstra commented Jan 12, 2014

jlaanstra commented Jan 12, 2014

anaisbetts commented Feb 17, 2014

clairernovotny commented Apr 1, 2014

clairernovotny commented Apr 1, 2014

shiftkey commented Jul 7, 2014

jen20 commented Jul 7, 2014

ammeep commented Jul 9, 2014

Ship ReactiveUI 6.0 #434

Ship ReactiveUI 6.0 #434

Conversation

anaisbetts commented Dec 12, 2013

DO THIS BEFORE SHIPPING

What has Shipped:

Breaking Changes

Find And Replace Breaking Changes

tberman commented Dec 13, 2013

clairernovotny commented Dec 14, 2013

anaisbetts commented Dec 16, 2013

anaisbetts commented Dec 16, 2013

jlaanstra commented Dec 16, 2013

jlaanstra commented Dec 16, 2013

tberman commented Dec 16, 2013

anaisbetts commented Dec 18, 2013

clairernovotny commented Dec 18, 2013

anaisbetts commented Dec 18, 2013

clairernovotny commented Jan 5, 2014

clairernovotny commented Jan 6, 2014

jlaanstra commented Jan 12, 2014

anaisbetts commented Jan 12, 2014

jlaanstra commented Jan 12, 2014

jlaanstra commented Jan 12, 2014

anaisbetts commented Feb 17, 2014

Cool Ideas

What has Shipped:

Breaking Changes

DO THIS BEFORE SHIPPING

Find And Replace Breaking Changes

clairernovotny commented Apr 1, 2014

clairernovotny commented Apr 1, 2014

shiftkey commented Jul 7, 2014

jen20 commented Jul 7, 2014

ammeep commented Jul 9, 2014