Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Fix CodeCov Paths #259

Merged
merged 2 commits into from
Oct 27, 2020
Merged

housekeeping: Fix CodeCov Paths #259

merged 2 commits into from
Oct 27, 2020

Conversation

worldbeater
Copy link
Contributor

What kind of change does this PR introduce?

This PR should fix the broken codecov paths. Based on the changes introduced in reactiveui/ReactiveUI.Validation#156

What is the current behavior?

Currently, the paths are broken, and this results into the following error displayed in codecov web interface:

What is the new behavior?

Now, the paths should hopefully be fixed.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #259 into main will increase coverage by 4.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   53.89%   58.48%   +4.59%     
==========================================
  Files          17       23       +6     
  Lines         488      542      +54     
  Branches       80        0      -80     
==========================================
+ Hits          263      317      +54     
- Misses        200      225      +25     
+ Partials       25        0      -25     
Impacted Files Coverage Δ
src/Sextant/Platforms/net461/SextantExtensions.cs
src/Sextant.Mocks/ParameterViewModel.cs 91.66% <0.00%> (ø)
src/Sextant.Mocks/NavigationViewMock.cs 59.09% <0.00%> (ø)
src/Sextant.Mocks/NullViewModelMock.cs 0.00% <0.00%> (ø)
src/Sextant.Mocks/NavigableViewModelMock.cs 90.00% <0.00%> (ø)
src/Sextant.Mocks/PageView.cs 0.00% <0.00%> (ø)
...tant/Platforms/netstandard2.0/SextantExtensions.cs 75.00% <0.00%> (ø)
src/Sextant.Mocks/NavigatedMock.cs 0.00% <0.00%> (ø)
src/Sextant/Navigation/ViewStackServiceBase.cs 91.37% <0.00%> (+4.19%) ⬆️
src/Sextant/Sextant.cs 92.30% <0.00%> (+7.69%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78ba9f...b4c95a9. Read the comment docs.

@worldbeater
Copy link
Contributor Author

worldbeater commented Oct 27, 2020

Should be fixed now https://codecov.io/gh/reactiveui/Sextant/src/9566c42060ded60bdac6cce8091fa3c65768245c/src/Sextant.XamForms/SextantHelper.cs

Codecov
Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA.

@worldbeater worldbeater marked this pull request as ready for review October 27, 2020 18:42
@worldbeater
Copy link
Contributor Author

The coverage increase is due to us migrating from opencover to cobertura.

@glennawatson glennawatson merged commit e38287c into main Oct 27, 2020
@glennawatson glennawatson deleted the fix-codecov-paths branch October 27, 2020 20:35
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants