Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ParameterViewStackService passing null on construction #309

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

RLittlesII
Copy link
Member

What kind of change does this PR introduce?

fixes: #306

What is the current behavior?

The base implementation is passing null expecting the value to come from registration.

What is the new behavior?

The constructor provides a new instance.

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #309 (2fd2b9a) into main (88b7f0e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          31       31           
  Lines         809      809           
=======================================
  Hits          536      536           
  Misses        273      273           
Impacted Files Coverage Δ
...rc/Sextant/Navigation/ParameterViewStackService.cs 100.00% <100.00%> (ø)
src/Sextant/Navigation/ViewStackService.cs 100.00% <100.00%> (ø)
src/Sextant/Navigation/ViewStackServiceBase.cs 93.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b7f0e...2fd2b9a. Read the comment docs.

@glennawatson glennawatson merged commit e1cdd7e into main Dec 31, 2020
@glennawatson glennawatson deleted the gh/306 branch December 31, 2020 01:23
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When calling Locator.CurrentMutable.RegisterNotificationView get exception
2 participants