Change folder path to avoid implicit NuGet inclusions

[sharwell]

@Mike-E-angelo I'm hoping we can use something like this PR to avoid needing to move these files completely outside the analyzers folder.

Fixes #1216 (comment)

[Mike-E-angelo]

Yeah it appears that any reference to this:

	<ItemGroup>
        <Analyzer Include="$(MSBuildThisFileDirectory)../../analyzers/cs-roslyn40/*.dll" />
    </ItemGroup>

Generates exceptions at build time. I am curious on why removing it still loads it into ServiceHub.RoslynCodeAnalysisService.exe. If NuGet is auto-loading this into ServiceHub.RoslynCodeAnalysisService.exe shouldn't we remove this ItemGroup altogether?

That is, based on my understanding, the source generator generates the class files, which are then picked up by the traditional MSBuild process during build. The MSBuild process does not need to reference the above, correct? Still trying to understand things here. :)

[sharwell]

OK this is going to be more annoying than I expected. I have to move these assemblies completely outside the analyzers folder. I'll update this PR.

https://github.com/dotnet/NuGet.BuildTasks/blob/b2f0c162994237c4a9c23af79d95f79847499ebd/src/Microsoft.NuGet.Build.Tasks/ResolveNuGetPackageAssets.cs#L468-L477

GitHub

NuGet.BuildTasks/ResolveNuGetPackageAssets.cs at b2f0c162994237c4a9c23af79d95f79847499ebd · dotnet/NuGet.BuildTasks

The build tasks used to pick up package content from project.lock.json. - NuGet.BuildTasks/ResolveNuGetPackageAssets.cs at b2f0c162994237c4a9c23af79d95f79847499ebd · dotnet/NuGet.BuildTasks

[clairernovotny]

Should this be merged?

[clairernovotny]

I'm going to go with yes :) I was confused by the close/reopen.

[sharwell]

I was confused by the close/reopen.

Build had issues the first time; close/reopen triggered a new one.

[Mike-E-angelo]

Woohoo... I can confirm that this works like a champ now with 6.1.5-preview. Thank you so much for doing this! It really means a lot to me personally as there are a lot of fires burning in my world and this it makes one less of them. :)

I appreciate the dedication to ensuring a high level of quality to your work out there. 👍🙏

[clairernovotny]

@sharwell should I release this as stable?

[sharwell]

@clairernovotny the specific risk is as follows:

• If a consumer uses this package outside of NuGet tooling, or in a manner that doesn't add a source generator assembly from the customized location, InterfaceStubGenerator will not execute. If the build is likely to still succeed in this scenario (i.e. no compiler errors due to missing generated code), it's possible this user would experience a silent breaking change. This is a risk area for Refit authors to review.
• For a while, the incremental source generator APIs were considered experimental and were only enabled if a consumer manually enabled <LangVersion>preview</LangVersion> in their project. If this behavior has not changed, it's possible for a user to experience a silent break inside the IDE for Visual Studio 2022. This is a risk area for @chsienki to review.

All other potentially problematic cases should consistently use the old implementation (Roslyn 3.8 APIs) during builds, so even if there are bugs in the Roslyn 4.0 portion it should not manifest in the build outputs. Once confidence is built in the Roslyn 4.0 implementation, we can update the integration to leverage upcoming VBCSCompiler support for incrementally running source generators during builds.

[sharwell]

I think we need to update this to gate the new incremental implementation on <LangVersion> in addition to IDE version.

https://github.com/dotnet/roslyn/blob/c083dae9fcb112d82c18b89687b9af65e7ef77b7/src/Compilers/CSharp/Portable/SourceGeneration/CSharpGeneratorDriver.cs#L27

GitHub

roslyn/CSharpGeneratorDriver.cs at c083dae9fcb112d82c18b89687b9af65e7ef77b7 · dotnet/roslyn

The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs. - roslyn/CSharpGeneratorDriver.cs at c083dae9fcb112d82c18b89687b9af65e7ef77b7 · dotnet/roslyn

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.