Fix generated usings in inherited interfaces #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreamescaper
commented
Apr 7, 2020
| @@ -370,6 +372,16 @@ string GetInterfaceName(SyntaxToken identifier) | |||
| public class UsingDeclaration | |||
| { | |||
| public string Item { get; set; } | |||
|
|
|||
| public override bool Equals(object obj) | |||
There was a problem hiding this comment.
Added Equals and GetHashCode so that Union above would work properly.
|
This was super quick, thank you @Dreamescaper! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #892
What is the current behavior?
If we have
InterfaceBinheritingInterfaceA, during generation ofInterfaceBwe include all methods fromInterfaceA. However - usings are not accounted, therefore ifInterfaceArequires some using directive, that is not present inInterfaceBfile, generated file will be broken.What is the new behavior?
Take all using directives from
InterfaceAfile to generatedInterfaceBimplementation.What might this PR break?
Technically it might lead to similar issue as #784. Including usings from several files might lead to conflicts.
However, in this case it applies only to inherited types, so probability is much lower.
Not sure if we can fully handle that without full semantic analysis.
Please check if the PR fulfills these requirements