Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating rendering-elements.md #10

Merged
merged 4 commits into from Jun 26, 2019
Merged

Conversation

omar-dulaimi
Copy link
Contributor

No description provided.

@omar-dulaimi omar-dulaimi changed the title translated elements' caption Translating rendering elements Feb 16, 2019
@asantarissy asantarissy self-assigned this Feb 16, 2019
@asantarissy asantarissy self-requested a review February 16, 2019 00:27
@asantarissy
Copy link
Member

@omar-dulaimi what's the status on this?

@omar-dulaimi
Copy link
Contributor Author

@omar-dulaimi what's the status on this?

Hey @asantarissy sorry for the wait, I will upload new changes by the end of today fo sure. And I might ask for another page if you like my translation.

@asantarissy
Copy link
Member

@omar-dulaimi what's the status on this?

Hey @asantarissy sorry for the wait, I will upload new changes by the end of today fo sure. And I might ask for another page if you like my translation.

That's great @omar-dulaimi 💪🏼
Let me know if you need any help.

@asantarissy
Copy link
Member

Hello @omar-dulaimi, @iRayan7 created a new Glossary wiki, please use it as a reference and keep checking it as it's WIP.

Cheers!

@Emmanuel-Melon
Copy link

Emmanuel-Melon commented Feb 23, 2019 via email

@asantarissy asantarissy changed the title Translating rendering elements Translating rendering-elements.md Feb 23, 2019
@asantarissy asantarissy removed their assignment Feb 27, 2019
@asantarissy
Copy link
Member

Hello @omar-dulaimi, what's the status? should we assign it to another contributor?

@omar-dulaimi
Copy link
Contributor Author

Hey @asantarissy I'm sorry it just got so busy these days that I'm not on github a lot anymore. I will try my best to do it as soon as possible

@asantarissy asantarissy self-assigned this Mar 24, 2019
@iRayan7 iRayan7 added the update needed This PR needs update since last commit label Jun 25, 2019
@iRayan7
Copy link
Member

iRayan7 commented Jun 25, 2019

Hi @omar-dulaimi, any updates?

@omar-dulaimi
Copy link
Contributor Author

Hey @iRayan7 I will push it once I get home today, sorry for the long wait I just had been really busy lately

@netlify
Copy link

netlify bot commented Jun 26, 2019

Deploy preview for ar-reactjs ready!

Built with commit 2ab325c

https://deploy-preview-10--ar-reactjs.netlify.com

@iRayan7
Copy link
Member

iRayan7 commented Jun 26, 2019

Amazing work @omar-dulaimi 👏

@iRayan7 iRayan7 merged commit 0474964 into reactjs:master Jun 26, 2019
@iRayan7 iRayan7 added approved and removed update needed This PR needs update since last commit work-in-progress labels Jun 26, 2019
@omar-dulaimi
Copy link
Contributor Author

@iRayan7 thank you

@omar-dulaimi omar-dulaimi deleted the startingOut branch June 27, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants