Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating tutorial.md #4

Closed

Conversation

Emmanuel-Melon
Copy link

No description provided.

@iRayan7
Copy link
Member

iRayan7 commented Feb 12, 2019

Hey Emmanuel, thanks for starting!
I would highly recommend waiting for review before merging your pr.
Thanks 🙏

@asantarissy
Copy link
Member

@Emmanuel-Melon what's the status on this?

@Emmanuel-Melon
Copy link
Author

@Emmanuel-Melon what's the status on this?

Almost done, will push code soon.

@asantarissy
Copy link
Member

Hello @Emmanuel-Melon, @iRayan7 created a new Glossary wiki, please use it as a reference and keep checking it as it's WIP.

Cheers!

@asantarissy asantarissy changed the title Switched repository && started translating tutorial page Translating tutorial.md Feb 23, 2019
@asantarissy
Copy link
Member

Hello @Emmanuel-Melon, anything on this, should we assign it to another contributor?

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Mar 17, 2019 via email

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Mar 17, 2019 via email

@iRayan7
Copy link
Member

iRayan7 commented Apr 11, 2019

Hi @Emmanuel-Melon, any updates on this PR?

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Apr 11, 2019 via email

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Apr 11, 2019 via email

@iRayan7
Copy link
Member

iRayan7 commented Apr 11, 2019

Thanks @Emmanuel-Melon 🙏

@iRayan7
Copy link
Member

iRayan7 commented Apr 20, 2019

Hi @Emmanuel-Melon, please make sure to update your translation according to Hsoub's https://wiki.hsoub.com/React/tutorial

@Emmanuel-Melon
Copy link
Author

Hi @Emmanuel-Melon, please make sure to update your translation according to Hsoub's https://wiki.hsoub.com/React/tutorial

Sure thing, I'm having issues with RTL support. Has it been added?

@aladin002dz
Copy link
Member

Hi @Emmanuel-Melon, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial

Sure thing, I'm having issues with RTL support. Has it been added?

yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Apr 20, 2019 via email

@aladin002dz
Copy link
Member

I'm using WebStorm and it has support for RTL but text looks disoriented when I run the server and view the pages on my browser, is that normal?

On Sat, Apr 20, 2019 at 12:12 PM Mahfoudh Arous @.***> wrote: Hi @Emmanuel-Melon <@Emmanuel-Melon>, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial Sure thing, I'm having issues with RTL support. Has it been added? yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AFAKVJAWZJMNPDA67IXXRZTPRLNATANCNFSM4GW62OKA> .

if you are on windows, try notepad++, I don't have issues with it

@Emmanuel-Melon
Copy link
Author

I'm using WebStorm and it has support for RTL but text looks disoriented when I run the server and view the pages on my browser, is that normal?

On Sat, Apr 20, 2019 at 12:12 PM Mahfoudh Arous @.***> wrote: Hi @Emmanuel-Melon <@Emmanuel-Melon>, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial Sure thing, I'm having issues with RTL support. Has it been added? yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AFAKVJAWZJMNPDA67IXXRZTPRLNATANCNFSM4GW62OKA> .

if you are on windows, try notepad++, I don't have issues with it

I'm done translating. Only adding links and checking out for typos.
Text still looks like this on my browser. Can I push my changes or there's something that I need to do?
Screenshot 2019-04-20 at 12 17 54

@aladin002dz
Copy link
Member

I'm using WebStorm and it has support for RTL but text looks disoriented when I run the server and view the pages on my browser, is that normal?

On Sat, Apr 20, 2019 at 12:12 PM Mahfoudh Arous @.***> wrote: Hi @Emmanuel-Melon <@Emmanuel-Melon>, please make sure to update your translation according to Hsoub's wiki.hsoub.com/React/tutorial Sure thing, I'm having issues with RTL support. Has it been added? yeah, it has been added, now you need to have it on your text editor, for me I am using on windows notepad++, it handles RTL better than VS Code, my default text editor — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <github.com/notifications/unsubscribe-auth/AFAKVJAWZJMNPDA67IXXRZTPRLNATANCNFSM4GW62OKA> .

if you are on windows, try notepad++, I don't have issues with it

I'm done translating. Only adding links and checking out for typos.
Text still looks like this on my browser. Can I push my changes or there's something that I need to do?
Screenshot 2019-04-20 at 12 17 54

may be, save the file you worked on then update your local repo: "git pull upstream" upstream is the original repo,

@iRayan7
Copy link
Member

iRayan7 commented Jun 25, 2019

Hi @Emmanuel-Melon, any updates?

@iRayan7 iRayan7 added the update needed This PR needs update since last commit label Jun 25, 2019
@@ -12,7 +12,7 @@ redirect_from:
- "docs/tutorial-zh-CN.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing this link to "docs/tutorial-ar.html"?

@iRayan7
Copy link
Member

iRayan7 commented Jun 26, 2019

@atefBB Would you like to translate this page? it's one of the most important ones. And I feel like you would do justice to it 👍

@atefBB
Copy link
Contributor

atefBB commented Jun 27, 2019

@iRayan7 What is the progress of the actual translation of the file? I see @Emmanuel-Melon starting the translation ! Any updates/help?!

@iRayan7
Copy link
Member

iRayan7 commented Jun 27, 2019

@atefBB I'm not sure. Open a new PR on it and I will assign it to you 👍

@iRayan7 iRayan7 closed this Jun 27, 2019
@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jun 27, 2019 via email

@atefBB
Copy link
Contributor

atefBB commented Jun 27, 2019

Hi @Emmanuel-Melon ! Can you send you translation as PR to review it?

@atefBB
Copy link
Contributor

atefBB commented Jun 27, 2019

@iRayan7 I think @Emmanuel-Melon still working on it !

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jun 27, 2019 via email

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jun 27, 2019 via email

@iRayan7
Copy link
Member

iRayan7 commented Jun 28, 2019

@Emmanuel-Melon Sorry about your laptop 💔. If it would take a long time to do a complete do over, I would suggest @atefBB to do it.
What do you think guys?

@iRayan7 iRayan7 reopened this Jun 28, 2019
@iRayan7 iRayan7 closed this Jun 28, 2019
@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jun 28, 2019 via email

@iRayan7
Copy link
Member

iRayan7 commented Jun 28, 2019

@Emmanuel-Melon Are you going to do the complete page? or only some parts of it?
If not the complete page, I think @atefBB would do it completely, so share it with him so he can complete it.

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jun 28, 2019 via email

@iRayan7
Copy link
Member

iRayan7 commented Jun 28, 2019

@Emmanuel-Melon Would like to complete it?

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jun 28, 2019 via email

@atefBB
Copy link
Contributor

atefBB commented Jun 28, 2019

@iRayan7 I haven't a laptop to complete the translation, I have a bad ux with github in my phone, so I can't help in translation in my case, but still can review changes. Sorry for disappoint.

@iRayan7
Copy link
Member

iRayan7 commented Jun 29, 2019

Yes, I'd like to complete it. However, I'm going to be very during this upcoming week. Is it possible to do it after?

How many days will take you to complete the translation?

@Emmanuel-Melon
Copy link
Author

Yes, I'd like to complete it. However, I'm going to be very during this upcoming week. Is it possible to do it after?

How many days will take you to complete the translation?

2 days.

@iRayan7
Copy link
Member

iRayan7 commented Jul 5, 2019

Yes, I'd like to complete it. However, I'm going to be very during this upcoming week. Is it possible to do it after?

How many days will take you to complete the translation?

2 days.

Hi @Emmanuel-Melon, Any update?

@Emmanuel-Melon
Copy link
Author

Emmanuel-Melon commented Jul 5, 2019 via email

@iRayan7
Copy link
Member

iRayan7 commented Jul 8, 2019

Ok @Emmanuel-Melon, I'm assigning it to another contributor 👍. Sorry for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update needed This PR needs update since last commit work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants