Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] translate "How to Contribute" #120

Merged
merged 10 commits into from
Aug 9, 2019

Conversation

Fcmam5
Copy link
Collaborator

@Fcmam5 Fcmam5 commented Jun 28, 2019

No description provided.

@netlify
Copy link

netlify bot commented Jun 28, 2019

Deploy preview for ar-reactjs ready!

Built with commit a46aab7

https://deploy-preview-120--ar-reactjs.netlify.com

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fcmam5 , thank you so much for the great job and your effort you're doing 🎓.
Please, I suggested some request to change some expression 📑. Can you check it out✒️?!
You may be right but this is just a view to be a clearer expression ✌🏻✔️.

content/docs/how-to-contribute.md Show resolved Hide resolved
content/docs/how-to-contribute.md Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@Fcmam5
Copy link
Collaborator Author

Fcmam5 commented Jun 28, 2019

@3imed-jaberi this PR is in "progress", I think that it doesn't make sense to review an unfinished work since it will have more commits for other parts of the page, and also some corrections when re-reading the translation

@3imed-jaberi
Copy link
Member

@3imed-jaberi this PR is in "progress", I think that it doesn't make sense to review an unfinished work since it will have more commits for other parts of the page, and also some corrections when re-reading the translation

I'm sorry .. I just want to give you some help in your first commit ..

@iRayan7
Copy link
Member

iRayan7 commented Jul 2, 2019

Hi @3imed-jaberi, please review this PR after it's been completed. and merge it when approved.

content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@Fcmam5 Fcmam5 changed the title [Work in progress] translate "How to Contribute" [Done] translate "How to Contribute" Jul 23, 2019
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شكرا لك اخي الكريم على عملك الرائع و مجهود في مساهماتك القيمة 💪🏻 ..

لقد قمت بإقتراح بعض التعديلات بالإضافة إلى التعديلات السابقة ..
يمكنك النظر إليها و شكرا لك

content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
content/docs/how-to-contribute.md Show resolved Hide resolved
content/docs/how-to-contribute.md Show resolved Hide resolved
content/docs/how-to-contribute.md Outdated Show resolved Hide resolved
@Fcmam5 Fcmam5 requested a review from 3imed-jaberi July 29, 2019 15:05
@Fcmam5 Fcmam5 requested a review from iRayan7 August 9, 2019 18:46
Copy link
Member

@iRayan7 iRayan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Amazing job

@iRayan7 iRayan7 merged commit c226d89 into reactjs:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants