Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating introducing-jsx.md #9

Merged
merged 7 commits into from Feb 17, 2019
Merged

Translating introducing-jsx.md #9

merged 7 commits into from Feb 17, 2019

Conversation

asantarissy
Copy link
Member

@asantarissy asantarissy commented Feb 15, 2019 •
edited

This page is done, I'd recommend if you pull my RTL PR #8 so you can review it correctly.

@tesseralis tesseralis mentioned this pull request Feb 15, 2019
Closed
Emmanuel-Melon
Emmanuel-Melon reviewed Feb 15, 2019
View reviewed changes
Copy link

@Emmanuel-Melon Emmanuel-Melon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is correct but it seems like the words have been shuffled. RTL support is needed.

@asantarissy
Copy link
Member Author

asantarissy commented Feb 15, 2019 •
edited

The translation is correct but it seems like the words have been shuffled. RTL support is needed.

Thanks @Emmanuel-Melon, this is work in progress 😄
And btw, I added you as a reviewer to another PR for the RTL support #8, please check it out and let me know your thoughts.

Cheers!

@asantarissy asantarissy merged commit ae8ddf2 into reactjs:master Feb 17, 2019
@asantarissy asantarissy deleted the translate-introducing-jsx.md branch December 1, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emmanuel-Melon Emmanuel-Melon Emmanuel-Melon approved these changes

@22mahmoud 22mahmoud Awaiting requested review from 22mahmoud

@iRayan7 iRayan7 Awaiting requested review from iRayan7

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asantarissy @Emmanuel-Melon