RTL Support #8
Merged
RTL Support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into rtl-support
Closed
|
@iRayan7 @22mahmoud @Emmanuel-Melon guys, do you have any comments on this? should I merge and close it? |
This was referenced Feb 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RTL support (#5) to all pages, sections and components, I did not translate anything so other RTL languages can benefit from this.
Also I kept Code examples and Live JSX Editors directions = LTR
Previews:
https://imgur.com/3T9mpam
https://imgur.com/6zaKQ6o
https://imgur.com/B8NupCw
https://imgur.com/jSsCSka
https://imgur.com/mgwdQHb