Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translated typechecking-with-proptypes #113

Merged
merged 19 commits into from Nov 17, 2019
Merged

translated typechecking-with-proptypes #113

merged 19 commits into from Nov 17, 2019

Conversation

ZweiDM
Copy link
Contributor

@ZweiDM ZweiDM commented Oct 28, 2019

Translated docs/typechecking-with-proptypes to german.

@netlify
Copy link

netlify bot commented Oct 28, 2019 •
edited

Deploy preview for de-reactjs ready!

Built with commit ccc3f2b

https://deploy-preview-113--de-reactjs.netlify.com

@ZweiDM ZweiDM mentioned this pull request Oct 28, 2019
Closed
91 tasks
@ZweiDM ZweiDM closed this Nov 7, 2019
@ZweiDM ZweiDM reopened this Nov 7, 2019
svenjungnickel
svenjungnickel suggested changes Nov 9, 2019
View reviewed changes
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
svenjungnickel
svenjungnickel suggested changes Nov 9, 2019
View reviewed changes
Copy link

@svenjungnickel svenjungnickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment in line 140 is also not translated yet (// This must be exactly one element or it will warn.). For some reason I could not edit this line. Can the author add this missing translation as well please?

ZweiDM and others added 12 commits November 10, 2019 17:41
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
aa19fca 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
d1dc8cd 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
9d00e89 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
d5c6202 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
90ab5d9 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
db13919 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
14007cc 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
05a665a 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
984a129 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
ce2f77c 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
@ZweiDM @svenjungnickel
Update content/docs/typechecking-with-proptypes.md
fda2b42 
Co-Authored-By: Sven Jungnickel <svenjungnickel@googlemail.com>
Translated a forgotten code comment in line 140.
1242087
@ZweiDM
Copy link
Contributor Author

ZweiDM commented Nov 10, 2019

The comment in line 140 is also not translated yet (// This must be exactly one element or it will warn.). For some reason I could not edit this line. Can the author add this missing translation as well please?

Thanks for your help. I fixed this in my last commit.

ph1p
ph1p requested changes Nov 11, 2019
View reviewed changes
Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Nov 11, 2019
@ZweiDM @ph1p
Update content/docs/typechecking-with-proptypes.md
e3512b1 
Co-Authored-By: Phil <phil@capshake.com>
ZweiDM and others added 2 commits November 13, 2019 08:24
@ZweiDM @ph1p
Update content/docs/typechecking-with-proptypes.md
33ee1d2 
Co-Authored-By: Phil <phil@capshake.com>
@ZweiDM @ph1p
Update content/docs/typechecking-with-proptypes.md
b603fd3 
Co-Authored-By: Phil <phil@capshake.com>
ZweiDM and others added 2 commits November 17, 2019 14:10
@ZweiDM @ph1p
Update content/docs/typechecking-with-proptypes.md
b768807 
Co-Authored-By: Phil <phil@capshake.com>
@ZweiDM @ph1p
Update content/docs/typechecking-with-proptypes.md
ccc3f2b 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Nov 17, 2019
@ph1p ph1p merged commit f176920 into reactjs:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wogsland wogsland wogsland left review comments

@ph1p ph1p ph1p requested changes

@svenjungnickel svenjungnickel svenjungnickel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZweiDM @wogsland @svenjungnickel @ph1p