Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/components-and-props.md #14

Merged
merged 33 commits into from Feb 18, 2019
Merged

docs/components-and-props.md #14

merged 33 commits into from Feb 18, 2019

Conversation

ph1p
Copy link
Member

@ph1p ph1p commented Feb 12, 2019

@miku86 @ChrisB9 I'm struggling with this sentence: This lets us use the same component abstraction for any level of detail. A button, a form, a dialog, a screen: in React apps, all those are commonly expressed as components.. Do you have any suggestions?

[EDIT]: Updated it!

@ph1p ph1p changed the title docs/components-and-props.md [WIP] docs/components-and-props.md Feb 12, 2019
@ph1p ph1p changed the title [WIP] docs/components-and-props.md docs/components-and-props.md Feb 14, 2019
@ph1p ph1p added the needs answers Some comments have not yet been finally answered. label Feb 14, 2019
@ph1p ph1p added completed - needs review 🧐 and removed needs answers Some comments have not yet been finally answered. 🚧 work in progress 🚧 labels Feb 15, 2019
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
content/docs/components-and-props.md Outdated Show resolved Hide resolved
ChrisB9 and others added 13 commits February 18, 2019 10:05
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
ph1p and others added 11 commits February 18, 2019 10:17
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Co-Authored-By: ph1p <phil@capshake.com>
Copy link
Collaborator

@ChrisB9 ChrisB9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afterwards it's good 👍

examples/components-and-props/rendering-a-component.js Outdated Show resolved Hide resolved
@ChrisB9 ChrisB9 merged commit 06140c0 into master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants