Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages/passing-functions-to-components #157

Merged
merged 4 commits into from Aug 3, 2020
Merged

Pages/passing-functions-to-components #157

merged 4 commits into from Aug 3, 2020

Conversation

pmaier983
Copy link
Contributor

Translate passing-functions-to-components page into german (#1).

@netlify
Copy link

netlify bot commented Jul 19, 2020 •
edited

Deploy preview for de-reactjs ready!

Built with commit 32b5a1b

https://deploy-preview-157--de-reactjs.netlify.app

ph1p
ph1p requested changes Jul 20, 2020
View reviewed changes
Copy link
Member

@ph1p ph1p left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pmaier983 ! First of all thank you for your contribution :)
I have added some suggestions. Please read your translation again, so I can merge them.

we have decided to use "du" in the translations (#26)

content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
@ph1p ph1p added the needs review from author First review completed. All changes are processed and a final review is required. label Jul 20, 2020
@pmaier983
Copy link
Contributor Author

Hey @ph1p. Cool name btw. I'll correct the translation and fix whats missing next weekend (can be sooner if need be). Thank you for reviewing!

@pmaier983
Copy link
Contributor Author

Sorry to ping you @ph1p, but whenever you get a chance I think this PR is fully cooked. Just wanted to put this on your radar!

@ph1p
Copy link
Member

ph1p commented Jul 27, 2020

Sorry to ping you @ph1p, but whenever you get a chance I think this PR is fully cooked. Just wanted to put this on your radar!

All right! I'll take a second look at it and if everything's okay, I'll merge it. Thanks (:

@ph1p ph1p added completed - needs review 🧐 and removed needs review from author First review completed. All changes are processed and a final review is required. labels Jul 27, 2020
ph1p
ph1p requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are the last change requests. Please take a look and we can merge them.

content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
content/docs/faq-functions.md Outdated Show resolved Hide resolved
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Jul 27, 2020
@pmaier983
Copy link
Contributor Author

@ph1p Thank you for being so thorough and helpful!

@ph1p
Copy link
Member

ph1p commented Aug 3, 2020

Okay, I think it's ready to merge. Thank you! (:

@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Aug 3, 2020
@ph1p ph1p merged commit d13f4a8 into reactjs:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph1p ph1p ph1p requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmaier983 @ph1p