Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/german translation hooks-custom #168

Merged
merged 5 commits into from
May 10, 2021

Conversation

timidak
Copy link
Contributor

@timidak timidak commented Oct 8, 2020

German translation hooks-custom

-->
#1

@netlify
Copy link

netlify bot commented Oct 8, 2020

Deploy preview for de-reactjs ready!

Built with commit 03562bb

https://deploy-preview-168--de-reactjs.netlify.app

@timidak timidak changed the title WIP: german translation hooks-custom WIP: Docs/german translation hooks-custom Oct 8, 2020
@vercel
Copy link

vercel bot commented Mar 5, 2021

@timidak is attempting to deploy a commit to the Facebook Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@timidak timidak changed the title WIP: Docs/german translation hooks-custom Docs/german translation hooks-custom May 7, 2021
@timidak
Copy link
Contributor Author

timidak commented May 7, 2021

@ph1p the PR is ready to review 😄

Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I have only a few suggestions (:

content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
content/docs/hooks-custom.md Outdated Show resolved Hide resolved
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels May 7, 2021
Co-authored-by: Phil <phil@capshake.com>
@timidak timidak requested a review from ph1p May 8, 2021 08:10
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label May 10, 2021
@ph1p ph1p merged commit f6dcf06 into reactjs:master May 10, 2021
@timidak timidak deleted the docs/building-your-own-hooks-translation branch May 10, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants