translate conditional rendering page #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for de-reactjs ready! Built with commit d70b84f |
ph1p
reviewed
Feb 24, 2019
91 tasks
ChrisB9
requested changes
Feb 24, 2019
|
Hi @ph1p, I really appreciate your suggestions. I've updated the PR with your suggested wording and added codepen examples. Unfortunately the translated codepens don't include CSS like the english ones because .css files currently aren't recognized by the codepen generator. I checked a couple of other language translation repos how they deal with this problem -> They just don't translate the code examples. What's your opinion about how we should handle this issue? |
ChrisB9
approved these changes
Feb 24, 2019
|
Translating code examples is more consistent in my opinion, but if it is technically currently not possible, then we should skip it for now and focus on the things that are still open.. |
ph1p
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 馃憢
This PR contains the translation of the 'Conditional Rendering' page.
I left the codepen links untouched because I only translated comments and display text into german so that the difference might not have a huge impact on the reader.
If you find that inappropriate there are two possible solutions coming to my mind: