Translate Composition vs Inheritance

[codejet]

Two things I'm not 100% sure about (apart from punctuation 🙈):

• "containment": I chose "Eingrenzung" now but originally had "Kapselung" in there. "Kapselung" is usually used to translate "encapsulation" though...
• "holes": I used "Lücken" instead of "Löcher" as it somehow sounded more appropriate to me.

BTW: any news on the glossary/styleguide?

[netlify]

Deploy preview for de-reactjs ready!

Built with commit 0d36548

https://deploy-preview-30--de-reactjs.netlify.com

[ph1p]

BTW: any news on the glossary/styleguide?

What do you mean? Should we add these words?

containment, holes

I think both (Eingrenzung and Lücken) are fine for the moment.

---

I don't think we should translate all things word for word. If the sentence makes sense and nothing loses its meaning, everything is fine.

[codejet]

Thanks a lot for the review @ph1p!

Regarding the glossary/styleguide: I was referring to this sentence in #1 - "Before contributing, read the glossary and style guide (once they exist)". Since there are no links I thought those documents do not exist yet.

[ph1p]

Thanks a lot for the review @ph1p!

Regarding the glossary/styleguide: I was referring to this sentence in #1 - "Before contributing, read the glossary and style guide (once they exist)". Since there are no links I thought those documents do not exist yet.

Your totally right! I found this at the spanish repo: https://github.com/reactjs/es.reactjs.org/blob/master/TRANSLATION.md#style-guide and this at the brasilian https://github.com/reactjs/pt-BR.reactjs.org/blob/master/GLOSSARY.md. We should do the same.