New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate DOM Elements #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for de-reactjs ready! Built with commit d8b18ab |
JohannesKlauss
suggested changes
Mar 4, 2019
Suggestions from review Co-Authored-By: fnoah <fnoah@users.noreply.github.com>
Co-Authored-By: fnoah <fnoah@users.noreply.github.com>
As far as I'm concerned this should be ready for a final review. |
ph1p
requested changes
Mar 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some suggestions, but in sum 👍
Co-Authored-By: fnoah <fnoah@users.noreply.github.com>
ph1p
approved these changes
Mar 6, 2019
ph1p
added
needs review from author
First review completed. All changes are processed and a final review is required.
and removed
needs answers
Some comments have not yet been finally answered.
labels
Mar 6, 2019
ChrisB9
approved these changes
Mar 6, 2019
91 tasks
ph1p
removed
the
needs review from author
First review completed. All changes are processed and a final review is required.
label
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.