Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate DOM Elements #37

Merged
merged 6 commits into from Mar 6, 2019
Merged

Translate DOM Elements #37

merged 6 commits into from Mar 6, 2019

Conversation

fnoah
Copy link
Contributor

@fnoah fnoah commented Mar 2, 2019

No description provided.

@netlify
Copy link

netlify bot commented Mar 2, 2019

Deploy preview for de-reactjs ready!

Built with commit d8b18ab

https://deploy-preview-37--de-reactjs.netlify.com

@fnoah fnoah marked this pull request as ready for review March 3, 2019 19:28
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
JohannesKlauss and others added 3 commits March 4, 2019 21:53
Suggestions from review

Co-Authored-By: fnoah <fnoah@users.noreply.github.com>
Co-Authored-By: fnoah <fnoah@users.noreply.github.com>
@fnoah
Copy link
Contributor Author

fnoah commented Mar 6, 2019

As far as I'm concerned this should be ready for a final review.

Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some suggestions, but in sum 👍

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@ph1p ph1p added the needs answers Some comments have not yet been finally answered. label Mar 6, 2019
Co-Authored-By: fnoah <fnoah@users.noreply.github.com>
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed needs answers Some comments have not yet been finally answered. labels Mar 6, 2019
@ph1p ph1p merged commit 04a0f48 into reactjs:master Mar 6, 2019
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants