Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated reference/react-dom-server #39

Merged
merged 2 commits into from Mar 19, 2019
Merged

Translated reference/react-dom-server #39

merged 2 commits into from Mar 19, 2019

Conversation

damienxy
Copy link
Contributor

@damienxy damienxy commented Mar 4, 2019

No description provided.

@netlify
Copy link

netlify bot commented Mar 4, 2019 •
edited

Deploy preview for de-reactjs ready!

Built with commit aa76e30

https://deploy-preview-39--de-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Mar 6, 2019
Closed
91 tasks
mbrandau
mbrandau reviewed Mar 9, 2019
View reviewed changes
Copy link

@mbrandau mbrandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation so far. 👍
I've commented on a few lines, that I would translate differently.

content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Mar 13, 2019
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Mar 19, 2019
@ph1p ph1p merged commit 9325251 into reactjs:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandau mbrandau mbrandau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damienxy @mbrandau @ph1p