Translating docs/accessibility #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for de-reactjs ready! Built with commit 17529b0 |
91 tasks
ph1p
requested changes
Aug 21, 2019
miku86
reviewed
Aug 26, 2019
miku86
reviewed
Aug 26, 2019
miku86
reviewed
Aug 26, 2019
|
@r3sMetz please do something. This PR needs only some minutes to finish and we can merge it :) |
ph1p
reviewed
Nov 18, 2019
ph1p
reviewed
Nov 18, 2019
ph1p
added
idle
keep suggested change at line 11 Co-Authored-By: Phil <phil@capshake.com>
keep suggested changes at line 17 Co-Authored-By: Phil <phil@capshake.com>
keep suggested changes at line 29 Co-Authored-By: Phil <phil@capshake.com>
Keep suggested change at line 47 Co-Authored-By: Phil <phil@capshake.com>
Keep suggested changes at line 75 Co-Authored-By: Phil <phil@capshake.com>
|
Sorry for the (way to long) time of beeing inactive, @ph1p i just added you on twitter, got some questions if and how to resume |
|
@ph1p I cant send you messages though, checked every channel :D |
ph1p
removed
the
idle
|
Nice work! Thank you for finishing it (: |
|
So i just have to finish these right here, and then it's done? |
|
yes :D but only if you think, these suggestions are correct |
Accept changes on line 93 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 110 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 113 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 115 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 116 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 119 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 128 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 135 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 137 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 139 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestion on line 141 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 149 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 151 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 158 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestions on line 164 Co-Authored-By: Phil <phil@capshake.com>
|
Think i've found all suggestions and accepted everyone but two. Am i just waiting for the suggesting persons to eventually change their requests, after debate? |
Accept suggestions on line 110 + 111 Co-Authored-By: Phil <phil@capshake.com>
Accept suggestion at line 145 Co-Authored-By: Phil <phil@capshake.com>
|
Okay, back in business, i guess. Thanks for your help and patience so far! |
ph1p
approved these changes
Dec 22, 2019
ph1p
removed
the
needs review from author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.